Negotiate the FTPS data channel protection level - #979
Open
slachiewicz wants to merge 1 commit into
Open
Conversation
An FTPS session encrypted only on the control channel is refused by any server that requires protection, with "425 Server requires protected data connection". PROT can only be sent once authenticated, hence the post-login hook rather than more work in createClient. The default is P because a caller asking for FTPS is asking for a protected transfer; set dataChannelProtection to C, or empty to send no PROT at all, for the previous behaviour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Master counterpart of #978, cherry-picked clean. See #651 for the report and #978 for the reasoning behind the default.
Verified on this branch:
mvn test -pl wagon-providers/wagon-ftp -am→ 27 tests, 0 failures.spotless:checkpasses.This change was created with AI assistance.