{bp-19394} fs/procfs: fix incorrect environ read for another task under CONFIG_ARCH_ADDRENV - #19611
Merged
Merged
Conversation
…RCH_ADDRENV Reading /proc/<pid>/group/env for another task dereferenced tg_envp under the caller's own address environment instead of the target task's, since tg_envp lives in the target's user heap. Switch to the target's address environment around the traversal, and to the caller's own environment only around the copy into the caller's buffer. Signed-off-by: liang.huang <liang.huang@houmo.ai>
jerpelea
requested review from
acassis,
cederom,
linguini1,
lupyuen and
xiaoxiang781216
August 3, 2026 07:42
jerpelea
changed the title
xiaoxiang781216
approved these changes
Aug 3, 2026
github-actions
Bot
added
Area: File System
Contributor
|
uhm, merging to releases/13.0 while 13.0.0 is already out?? why not releases/13.0.1 or 13.1.0 or similar? we should use X.Y.Z nomenclature in branches too? :-) |
Contributor
okay releases/13.0 is the branch for 13.0.Z that means next release will be 13.0.1 and these are identified by tags, thank you @jerpelea :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reading /proc//group/env for another task dereferenced tg_envp under the caller's own address environment instead of the target task's, since tg_envp lives in the target's user heap. Switch to the target's address environment around the traversal, and to the caller's own environment only around the copy into the caller's buffer.
Impact
RELEASE
Testing
CI