Skip to content

HDDS-15884. Allow GitHub avatar sources in blog CSP#495

Merged
jojochuang merged 1 commit into
apache:masterfrom
arunk-kumar:HDDS-15884
Jul 17, 2026
Merged

HDDS-15884. Allow GitHub avatar sources in blog CSP#495
jojochuang merged 1 commit into
apache:masterfrom
arunk-kumar:HDDS-15884

Conversation

@arunk-kumar

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Add https://github.com/ and https://*.githubusercontent.com/ to CSP_PROJECT_DOMAINS in static/.htaccess.

Please describe your PR in detail:

The blog contributor cards use image_url: https://github.com/<user>.png for individual authors (see blog/authors.yml). That URL 302-redirects to avatars.githubusercontent.com, so the browser needs CSP permission for both origins. No img-src is set today, so default-src applies and blocks the images — the contributor avatars don't render.

JIRA: https://issues.apache.org/jira/browse/HDDS-15884

Alternative

Bundle avatars into the repo and point authors.yml at local paths. Avoids the CSP change and the redirect hop, but every contributor add/refresh becomes a commit. Happy to switch if reviewers prefer.

How was this patch tested?

  • Redirect chain confirmed: curl -sI https://github.com/<user>.pngHTTP/2 302location: https://avatars.githubusercontent.com/..., so CSP must allow both origins.
  • Local httpd 2.4 smoke test with this .htaccess plus a stub Header set Content-Security-Policy ... %{CSP_PROJECT_DOMAINS}e ... emits both https://github.com/ and https://*.githubusercontent.com/ in the resulting header. Reverting the patch drops both origins; restoring it puts them back.

@jojochuang
jojochuang merged commit 5c028f7 into apache:master Jul 17, 2026
10 checks passed
@jojochuang

Copy link
Copy Markdown
Contributor

Merged. Thanks @arunk-kumar

@arunk-kumar
arunk-kumar deleted the HDDS-15884 branch July 18, 2026 08:42
errose28 added a commit to errose28/ozone-site that referenced this pull request Jul 20, 2026
* master: (34 commits)
  HDDS-15915. Document Recon chatbot gateway provider and update JCEKS setup in admin guide. (apache#496).
  HDDS-15801. Add blogs on S3 compatibility and S3 conditional requests (apache#488)
  HDDS-14343. Apache Knox integration documentation and Docker Compose demo (apache#490)
  HDDS-15884. Allow GitHub avatar sources in blog CSP (apache#495)
  HDDS-15878. Update the Roadmap After releasing 2.2.0 (apache#494)
  HDDS-15506. Update Ozone website for 2.2.0 release (apache#492)
  HDDS-14082. Add Hue integration guide and verification compose stack (apache#203)
  HDDS-15767. Update system internal docs since pull replication is removed (apache#489)
  HDDS-15746. [Auto] Update configuration documentation (apache#487)
  HDDS-15619. Add user documentation for Recon AI Assistant. (apache#469)
  HDDS-15017. [Website v2] [Docs] [Administrator Guide] Directory Configurations for Datanode. (apache#392)
  HDDS-15018. [Website v2] [Docs] [Administrator Guide] Directory Configurations for Recon. (apache#393)
  HDDS-15613. Publish the Read Operation Implementation doc (apache#484)
  HDDS-15683. Updated doc for Supported Grafana version (apache#475)
  HDDS-15714. Group actions/cache version bumps (apache#479)
  HDDS-15725. zizmor check should reflect failure in fork (apache#483)
  HDDS-14733. Standardize the usage of the term IO in the documentation (apache#486)
  HDDS-15719. Add check for allowed action usage in workflows (apache#485)
  HDDS-15584. Add supported awscli version paragraph to user guide (apache#482)
  HDDS-15707. Bump Docusaurus from 3.7.0 to 3.10.1 (apache#481)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants