Skip to content

HDDS-8320. Remove exclusion of jackson from ranger-intg #4497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
smengcl wants to merge 3 commits into from
Closed

HDDS-8320. Remove exclusion of jackson from ranger-intg #4497

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
25a911c
HDDS-8320. Remove exclusion of jackson from ranger-intg
smengcl Mar 29, 2023
a35b66a
Revert "HDDS-8320. Remove exclusion of jackson from ranger-intg"
smengcl Mar 29, 2023
1e65a8d
Explicitly import jackson-core-asl back instead due to dependency con…
smengcl Mar 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions hadoop-ozone/ozone-manager/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,13 @@ https://maven.apache.org/xsd/maven-4.0.0.xsd">
<artifactId>jersey-client</artifactId>
</dependency>

<!-- Overriding ranger-intg jackson version -->
<dependency>
<groupId>org.codehaus.jackson</groupId>
<artifactId>jackson-core-asl</artifactId>
<version>${jackson1.version}</version>
</dependency>
Comment on lines +161 to +165
Copy link
Contributor

@adoroszlai adoroszlai Mar 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what Ranger brings without the exclusion:

[INFO] |     +- org.codehaus.jackson:jackson-jaxrs:jar:1.9.13:compile
[INFO] |     |  +- org.codehaus.jackson:jackson-core-asl:jar:1.9.13:compile
[INFO] |     |  \- org.codehaus.jackson:jackson-mapper-asl:jar:1.9.13:compile

If we want to add explicit dependency, I think we should add jackson-jaxrs, not jackson-core-asl.

Copy link
Contributor Author

@smengcl smengcl Mar 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adoroszlai for looking at this. @swamirishi has added jaxrs in #4504 .

Copy link
Contributor

@swamirishi swamirishi Mar 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jaxrs doesn't have the internal build version. Ozone depends on specific internal build jackson-core-asl & jackson-mapper-asl. In order to fix this we need to exclude jackson-core-asl & jackson-mapper-asl from jackson-jaxrs & include the specified version to fix the conflict.

Copy link
Contributor

@swamirishi swamirishi Mar 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check #4504 for the fix.


<dependency>
<groupId>org.apache.ranger</groupId>
<artifactId>ranger-intg</artifactId>
Expand Down
1 change: 1 addition & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,7 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xs
<jersey2.version>2.34</jersey2.version>

<!-- jackson versions -->
<jackson1.version>1.9.13</jackson1.version>
<jackson2-bom.version>2.13.4.20221013</jackson2-bom.version>
<woodstox.version>5.4.0</woodstox.version>

Expand Down