[hive] Normalize column comments written to Hive metastore - #9073
Merged
JingsongLi merged 1 commit intoAug 6, 2026
Merged
Conversation
HiveCatalog passed DataField.description() to FieldSchema unchanged, so a column comment longer than 256 characters made the metastore reject the COLUMNS_V2 insert and fail the whole CREATE TABLE. Normalize the comment with the helper IcebergHiveMetadataCommitter already uses, moved to HiveTableUtils so both callers share it. Normalization is applied only where comments reach COLUMNS_V2. Partition keys are stored in PARTITION_KEYS.PKEY_COMMENT, which allows longer values, and are left untouched. Generated-by: Claude Code
Contributor
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
fix #9072
HiveCatalogpassedDataField.description()toFieldSchemaunchanged, so a comment longer than 256 characters made the metastore reject theCOLUMNS_V2insert and failCREATE TABLE.IcebergHiveMetadataCommitteralready uses ([hive] Truncate Iceberg Hive column comments for Glue compatibility #8223, [hive] Strip newline characters from Glue column comments #8918), moved toHiveTableUtilsso both callers share it.COLUMNS_V2comments are normalized; partition keys usePARTITION_KEYS.PKEY_COMMENT, which allows longer values, and stay untouched.Tests
HiveCatalogTest#testCreateTableWithLongColumnComment(300-character comment with a newline: create succeeds, the mirror is truncated to 255 characters, Paimon keeps the original) and#testCreateTableWithLongPartitionKeyComment.mvn -pl paimon-hive/paimon-hive-catalog -DfailIfNoTests=false clean installon JDK 11 — 76 tests passed.