[core] Fix stale default value in sort-compaction.range-strategy description - #9104
Open
jackylee-ch wants to merge 1 commit into
Open
[core] Fix stale default value in sort-compaction.range-strategy description#9104jackylee-ch wants to merge 1 commit into
jackylee-ch wants to merge 1 commit into
Conversation
…ription The description still said the default is quantity, but apache#6826 changed defaultValue to RangeStrategy.SIZE. Regenerated core_configuration.html.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
sort-compaction.range-strategydescribes itself as "the default value is quantity", but#6826 changed
defaultValuetoRangeStrategy.SIZE. The generated docs render both, so theDefault column says
SIZEwhile the description says quantity.Reworded the description to match, and rewrote the second sentence which described the old
default as the opt-in. Regenerated
core_configuration.html.Tests
ConfigOptionsDocsCompletenessITCase— passes; fails if the generated html is left stale.