Skip to content

[core] Fix stale default value in sort-compaction.range-strategy description #9104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jackylee-ch wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −5
Open

[core] Fix stale default value in sort-compaction.range-strategy description #9104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/generated/core_configuration.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1612,8 +1612,8 @@
<td><h5>sort-compaction.range-strategy</h5></td>
<td style="word-wrap: break-word;">SIZE</td>
<td><p>Enum</p></td>
<td>The range strategy of sort compaction, the default value is quantity.
If the data size allocated for the sorting task is uneven,which may lead to performance bottlenecks, the config can be set to size.<br /><br />Possible values:<ul><li>"SIZE"</li><li>"QUANTITY"</li></ul></td>
<td>The range strategy of sort compaction, the default value is size.
The size strategy ranges by the data size allocated to each sorting task, which avoids the performance bottlenecks caused by uneven data size. The config can be set to quantity to range by the number of rows instead.<br /><br />Possible values:<ul><li>"SIZE"</li><li>"QUANTITY"</li></ul></td>
</tr>
<tr>
<td><h5>sort-engine</h5></td>
Expand Down
7 changes: 4 additions & 3 deletions paimon-api/src/main/java/org/apache/paimon/CoreOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2166,9 +2166,10 @@ public String toString() {
.enumType(RangeStrategy.class)
.defaultValue(RangeStrategy.SIZE)
.withDescription(
"The range strategy of sort compaction, the default value is quantity.\n"
+ "If the data size allocated for the sorting task is uneven,which may lead to performance bottlenecks, "
+ "the config can be set to size.");
"The range strategy of sort compaction, the default value is size.\n"
+ "The size strategy ranges by the data size allocated to each sorting task, which avoids "
+ "the performance bottlenecks caused by uneven data size. "
+ "The config can be set to quantity to range by the number of rows instead.");

public static final ConfigOption<Integer> SORT_COMPACTION_SAMPLE_MAGNIFICATION =
key("sort-compaction.local-sample.magnification")
Expand Down
Loading