Closed
Conversation
* upgrade maven-shade-plugin to 3.5.2 * Remove build-shade jar profile
Jackie-Jiang
approved these changes
Apr 18, 2024
...test/java/org/apache/pinot/plugin/inputformat/parquet/ParquetNativeRecordReaderFullTest.java
Outdated
Show resolved
Hide resolved
| File dataFile = new File(URLDecoder.decode(getClass().getClassLoader().getResource(filePath).getFile(), "UTF-8")); | ||
| ParquetNativeRecordReader recordReader = new ParquetNativeRecordReader(); | ||
| recordReader.init(dataFile, null, null); | ||
| int counter = 0; |
Contributor
There was a problem hiding this comment.
Would it be more explicit if we count numDocsForFirstPass and numDocsForSecondPass and compare them? Can you also use try-with-resource to close the record reader (not introduced in this PR)
Contributor
Author
There was a problem hiding this comment.
For this PR, I can count numDocsForFirstPass and numDocsForSecondPass explicitly. This PR is mainly intended to add an assertion mechanism. Is it still necessary to use the try-with-resource in this PR?
Contributor
There was a problem hiding this comment.
E.g when the assert fails, it will leak resource because the last close() won't be executed. Using try-with-resource is just good practice to prevent resource leak
…hem (apache#12883) * skip missing segments while checking freshness during server startup * get new consuming segments again if current consuming segments are committed by other servers
Created new Action GET_SCHEDULER_JOB_DETAILS under the Table actions for the endpoint /tasks/scheduler/jobDetails as its fetching table level information and the existing action puts this endpoint under Cluster actions.
Change the multi-stage stats to return a tree like structure with stats per operator.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
18 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added assert statements to testParquetFile(String filePath) to ensure that test fails/passes are noted correctly
#12965