[fix][admin] Avoid creating subscriptions when peeking messages if auto-creation is disabled - #26279
Merged
nodece merged 1 commit intoAug 7, 2026
Conversation
void-ptr974
marked this pull request as ready for review
August 5, 2026 23:33
nodece
approved these changes
Aug 6, 2026
crossoverJie
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The peek messages Admin API implicitly creates a subscription at the earliest position when the requested subscription does not exist. This creation currently bypasses the effective
allowAutoSubscriptionCreationpolicy at the topic, namespace, and broker levels.As a result, a read-oriented Admin operation can create subscription metadata, retain backlog, and consume subscription quota even when automatic subscription creation is disabled.
Modifications
Verifying this change
This change added tests and can be verified as follows:
PersistentTopicsTest.testPeekWithSubscriptionNameNotExistto verify that:PreconditionFailedException;Does this pull request potentially affect one of the following parts:
peekMessagesnow reportsPreconditionFailedExceptionwhen the subscription is missing and automatic creation is disabled.