Skip to content

Conversation

@jiridanek
Copy link
Contributor

The workaround has outlived its usefulness and is now causing build failures.

This reverts commit 06c7e64

@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2022

Codecov Report

Merging #372 (c6b5e48) into main (d1bcaa3) will increase coverage by 20.04%.
The diff coverage is n/a.

❗ Current head c6b5e48 differs from pull request most recent head 69a6e4b. Consider uploading reports for the commit 69a6e4b to get more accurate results

@@             Coverage Diff             @@
##             main     #372       +/-   ##
===========================================
+ Coverage   68.29%   88.34%   +20.04%     
===========================================
  Files         367       47      -320     
  Lines       73216     2394    -70822     
===========================================
- Hits        50005     2115    -47890     
+ Misses      23211      279    -22932     
Impacted Files Coverage Δ
cpp/src/duration.cpp
build/c/src/core/frame_generators.c
cpp/src/sender.cpp
cpp/src/url_test.cpp
c/tests/thread.h
cpp/src/proton_bits.hpp
c/src/extra/url.c
c/src/core/autodetect.c
...on/test_PROTON_1800_syncrequestresponse_fd_leak.py
cpp/src/scalar_test.hpp
... and 310 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1bcaa3...69a6e4b. Read the comment docs.

…che#311)"

The workaround has outlived its usefulness and is now causing build failures.

This reverts commit 06c7e64
@jiridanek jiridanek force-pushed the jd_2022_05_18_component_not_found branch from d6832b6 to 69a6e4b Compare June 10, 2022 10:54
@jiridanek jiridanek merged commit bc364b9 into apache:main Jun 10, 2022
@jiridanek jiridanek deleted the jd_2022_05_18_component_not_found branch June 10, 2022 12:00
jiridanek added a commit to jiridanek/qpid-proton that referenced this pull request Mar 3, 2023
…che#311)" (apache#372)

The workaround has outlived its usefulness and is now causing build failures.

This reverts commit 06c7e64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants