[REEF-1191] Allow specification of log directories in job parameters#877
[REEF-1191] Allow specification of log directories in job parameters#877afchung wants to merge 1 commit intoapache:masterfrom
Conversation
|
|
||
| /// <summary> | ||
| /// Gets the file path for stdout for the driver. | ||
| /// </summary> |
There was a problem hiding this comment.
Could you add the same description here, too?
/// Certain runtimes may impose stricter policies on log file
/// output locations (e.g. YARN jobs have restricted write access
/// to certain folders).
There was a problem hiding this comment.
Whoops, sorry, I meant to remove that comment entirely, because it turned out not to be true -- I was just entering the paths incorrectly when I tried to test it out. I'll remove the message in the other places. Thanks!
|
Oh, @afchung . It fails on CI. Let's continue after fixing that first. :) |
|
@dongjoon-hyun Sorry, I only ran .NET tests prior to sending the PR. Let me fix the tests and close this first in the meantime. Thanks for the review! |
|
@dongjoon-hyun I've updated the PR, addressing your comments and fixing the broken tests. Please have another look. Thanks! |
|
Thank you for quick fixing, @afchung . |
|
Sorry, @afchung . I'm afraid I can't fix my build environment soon. |
|
@afchung Can you please resolve the merge conflicts here? |
|
@markusweimer Resolved, thanks! |
|
Do you have a test case for the change especially test running on YARN? |
|
@jwang98052 I'm not sure how you would test this on YARN, since the log location only specifies where the log lives and has no verifiable property in the job itself. |
|
@jwang98052 Ping... |
|
@afchung Could you please rebase again? |
JIRA: [REEF-1191] https://issues.apache.org/jira/browse/REEF-1191 Pull Request: Closes apache#877
|
@jwang98052 rebased. |
|
I will test and merge |
4 participants
JIRA:
[REEF-1191] https://issues.apache.org/jira/browse/REEF-1191
Pull Request:
Closes #