This repository was archived by the owner on Aug 4, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 92
[REEF-1191] Allow specification of log directories in job parameters #877
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
85 changes: 85 additions & 0 deletions
85
lang/cs/Org.Apache.REEF.Client/Avro/Local/AvroLocalJobSubmissionParameters.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,85 @@ | ||
| // Licensed to the Apache Software Foundation (ASF) under one | ||
| // or more contributor license agreements. See the NOTICE file | ||
| // distributed with this work for additional information | ||
| // regarding copyright ownership. The ASF licenses this file | ||
| // to you under the Apache License, Version 2.0 (the | ||
| // "License"); you may not use this file except in compliance | ||
| // with the License. You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, | ||
| // software distributed under the License is distributed on an | ||
| // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| // KIND, either express or implied. See the License for the | ||
| // specific language governing permissions and limitations | ||
| // under the License. | ||
| //<auto-generated /> | ||
|
|
||
| using System.Runtime.Serialization; | ||
| using Org.Apache.REEF.Utilities.Attributes; | ||
|
|
||
| namespace Org.Apache.REEF.Client.Avro.Local | ||
| { | ||
| /// <summary> | ||
| /// Used to serialize and deserialize Avro record | ||
| /// org.apache.reef.reef.bridge.client.avro.AvroLocalJobSubmissionParameters. | ||
| /// This is a (mostly) auto-generated class. | ||
| /// For instructions on how to regenerate, please view the README.md in the same folder. | ||
| /// </summary> | ||
| [Private] | ||
| [DataContract(Namespace = "org.apache.reef.reef.bridge.client.avro")] | ||
| public sealed class AvroLocalJobSubmissionParameters | ||
| { | ||
| private const string JsonSchema = @"{""type"":""record"",""name"":""org.apache.reef.reef.bridge.client.avro.AvroLocalJobSubmissionParameters"",""doc"":""Job submission parameters used by the local runtime"",""fields"":[{""name"":""sharedJobSubmissionParameters"",""type"":{""type"":""record"",""name"":""org.apache.reef.reef.bridge.client.avro.AvroJobSubmissionParameters"",""doc"":""General cross-language job submission parameters shared by all runtimes"",""fields"":[{""name"":""jobId"",""type"":""string""},{""name"":""jobSubmissionFolder"",""type"":""string""}]}},{""name"":""driverStdoutFilePath"",""type"":""string""},{""name"":""driverStderrFilePath"",""type"":""string""}]}"; | ||
|
|
||
| /// <summary> | ||
| /// Gets the schema. | ||
| /// </summary> | ||
| public static string Schema | ||
| { | ||
| get | ||
| { | ||
| return JsonSchema; | ||
| } | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// Gets or sets the sharedJobSubmissionParameters field. | ||
| /// </summary> | ||
| [DataMember] | ||
| public AvroJobSubmissionParameters sharedJobSubmissionParameters { get; set; } | ||
|
|
||
| /// <summary> | ||
| /// Gets or sets the driverStdoutFilePath field. | ||
| /// </summary> | ||
| [DataMember] | ||
| public string driverStdoutFilePath { get; set; } | ||
|
|
||
| /// <summary> | ||
| /// Gets or sets the driverStderrFilePath field. | ||
| /// </summary> | ||
| [DataMember] | ||
| public string driverStderrFilePath { get; set; } | ||
|
|
||
| /// <summary> | ||
| /// Initializes a new instance of the <see cref="AvroLocalJobSubmissionParameters"/> class. | ||
| /// </summary> | ||
| public AvroLocalJobSubmissionParameters() | ||
| { | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// Initializes a new instance of the <see cref="AvroLocalJobSubmissionParameters"/> class. | ||
| /// </summary> | ||
| /// <param name="sharedJobSubmissionParameters">The sharedJobSubmissionParameters.</param> | ||
| /// <param name="driverStdoutFilePath">The driverStdoutFilePath.</param> | ||
| /// <param name="driverStderrFilePath">The driverStderrFilePath.</param> | ||
| public AvroLocalJobSubmissionParameters(AvroJobSubmissionParameters sharedJobSubmissionParameters, string driverStdoutFilePath, string driverStderrFilePath) | ||
| { | ||
| this.sharedJobSubmissionParameters = sharedJobSubmissionParameters; | ||
| this.driverStdoutFilePath = driverStdoutFilePath; | ||
| this.driverStderrFilePath = driverStderrFilePath; | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29 changes: 29 additions & 0 deletions
29
lang/cs/Org.Apache.REEF.Client/YARN/Parameters/DriverStderrFilePath.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| // Licensed to the Apache Software Foundation (ASF) under one | ||
| // or more contributor license agreements. See the NOTICE file | ||
| // distributed with this work for additional information | ||
| // regarding copyright ownership. The ASF licenses this file | ||
| // to you under the Apache License, Version 2.0 (the | ||
| // "License"); you may not use this file except in compliance | ||
| // with the License. You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, | ||
| // software distributed under the License is distributed on an | ||
| // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| // KIND, either express or implied. See the License for the | ||
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| using Org.Apache.REEF.Tang.Annotations; | ||
|
|
||
| namespace Org.Apache.REEF.Client.YARN.Parameters | ||
| { | ||
| [NamedParameter("Driver stderr file path for YARN.", defaultValue: "<LOG_DIR>/driver.stderr")] | ||
| internal sealed class DriverStderrFilePath : Name<string> | ||
| { | ||
| private DriverStderrFilePath() | ||
| { | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add the same description here, too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops, sorry, I meant to remove that comment entirely, because it turned out not to be true -- I was just entering the paths incorrectly when I tried to test it out. I'll remove the message in the other places. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:)