fix(studio): make DLQ provider fail explicitly instead of returning stub data - #750
Closed
123123213weqw wants to merge 1 commit into
Closed
Conversation
…tub data DLQProviderStub was wired as the production DLQProvider but returned hard-coded sample DLQ groups and treated resendMessages as a no-op, which could mislead operators into believing real DLQ data exists and that resend requests succeeded. Until a real DLQ provider is connected, both operations now fail explicitly with a structured 501 Not Implemented BusinessException, matching the issue's expected behavior. Updated DLQProviderStubTest accordingly. Fixes apache#686
Member
|
Thanks for the contribution. This is already covered by #687, merged into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #686
Problem
DLQProviderStubis wired as the productionDLQProvider, but it:listDLQGroups, andresendMessagesas a no-op (only logs, never resends).Returning sample data and successful no-op responses can mislead operators into believing real DLQ groups exist and that resend requests actually succeeded.
Fix
Until a real DLQ provider is connected, both operations now fail explicitly with a structured
501 Not ImplementedBusinessException(whichGlobalExceptionHandlermaps to a cleanResult.error(501, ...)response), as the issue's "Expected" section calls for. The hard-coded stub data and its helper methods are removed.DLQProviderStubTestis updated to assert the new not-implemented behavior.Verification
mvn test -Dtest=DLQProviderStubTestpasses on JDK 21:Tests run: 3, Failures: 0, Errors: 0, Skipped: 0.Diff
2 files changed, +28 / -85.