fix(studio): make client provider fail explicitly instead of returning fake online clients - #752
Closed
123123213weqw wants to merge 1 commit into
Conversation
…g fake online clients ClientProviderStub was wired as the production ClientProvider but returned hard-coded sample connections (producer-001, consumer-001, consumer-002), which could mislead operators into believing real Remoting/gRPC clients are online. Until a real client provider is connected, findConnections now fails explicitly with a structured 501 Not Implemented BusinessException. Added ClientProviderStubTest for the new behavior. Fixes apache#696
Member
|
Thanks for the contribution. This is already covered by #697, merged into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #696
Problem
ClientProviderStubis wired as the productionClientProviderbut returns hard-coded sample connections (producer-001,consumer-001,consumer-002). The client connection page should not show production-looking fake clients when no real client provider is configured — it can mislead operators during validation.Fix
Until a real Remoting/gRPC client provider is connected,
findConnectionsnow fails explicitly with a structured501 Not ImplementedBusinessException(mapped byGlobalExceptionHandlertoResult.error(501, ...)), matching the issue's expected behavior. AddedClientProviderStubTest.Verification
mvn test -Dtest=ClientProviderStubTeston JDK 21:Tests run: 2, Failures: 0, Errors: 0, Skipped: 0.Diff
2 files changed.