[ISSUE #4501] fix Namesrv auto discovery not work#4502
Merged
duhenglucky merged 7 commits intoapache:developfrom Jul 11, 2022
francisoliverlee:develop
Merged
[ISSUE #4501] fix Namesrv auto discovery not work#4502duhenglucky merged 7 commits intoapache:developfrom francisoliverlee:develop
duhenglucky merged 7 commits intoapache:developfrom
francisoliverlee:develop
Conversation
from APACHE
merge from apache
Codecov Report
@@ Coverage Diff @@
## develop #4502 +/- ##
=============================================
- Coverage 48.25% 48.09% -0.16%
+ Complexity 5143 5113 -30
=============================================
Files 649 649
Lines 43037 43037
Branches 5629 5629
=============================================
- Hits 20766 20698 -68
- Misses 19768 19825 +57
- Partials 2503 2514 +11
Continue to review full report at Codecov.
|
lizhanhui
reviewed
Jun 23, 2022
| public String fetchNameServerAddr() { | ||
| try { | ||
| String addrs = this.topAddressing.fetchNSAddr(); | ||
| if (addrs != null) { |
Contributor
There was a problem hiding this comment.
UtillAll.isBlank already has nullable checking
| public String fetchNameServerAddr() { | ||
| try { | ||
| String addrs = this.topAddressing.fetchNSAddr(); | ||
| if (addrs != null) { |
Contributor
There was a problem hiding this comment.
UtillAll.isBlank already has nullable checking
RongtongJin
reviewed
Jun 30, 2022
| try { | ||
| String addrs = this.topAddressing.fetchNSAddr(); | ||
| if (addrs != null) { | ||
| if (addrs != null && !UtilAll.isBlank(addrs)) { |
Contributor
There was a problem hiding this comment.
It would be better to combine one with the following if.
| try { | ||
| String addrs = this.topAddressing.fetchNSAddr(); | ||
| if (addrs != null) { | ||
| if (addrs != null && !UtilAll.isBlank(addrs)) { |
Contributor
There was a problem hiding this comment.
It would be better to combine one with the following if.
from apache
merge from apache
duhenglucky
approved these changes
Jul 11, 2022
duhenglucky
added
type/enhancement
module/broker
LTS 4.9.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure set the target branch to
developWhat is the purpose of the change
XXXXX
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyleto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.