Skip to content

Update dependency com.lmax:disruptor to v4 (branch_9x) - #4857

Open
solrbot wants to merge 2 commits into
apache:branch_9xfrom
solrbot:renovate-9x/major-logging
Open

Update dependency com.lmax:disruptor to v4 (branch_9x)#4857
solrbot wants to merge 2 commits into
apache:branch_9xfrom
solrbot:renovate-9x/major-logging

Conversation

@solrbot

@solrbot solrbot commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

This PR contains the following updates:

Package Type Update Change
com.lmax:disruptor (source) dependencies major 3.4.44.0.0

Release Notes

LMAX-Exchange/disruptor (com.lmax:disruptor)

v4.0.0

Compare Source

  • Minimum Java version now 11
  • Issue #​323 - WorkerPool and WorkProcessor have been removed, no more Disruptor::handleEventsWithWorkerPool
  • Disruptor constructors using Executor have been removed. Use ThreadFactory instead.
  • Rolled up event handling extension interfaces on to EventHandler:
    • BatchStartAware
    • LifecycleAware
    • SequenceReportingEventHandler
  • FatalExceptionHandler and IgnoreExceptionHandler now use the JDK 9 Platform Logging API, i.e. System.Logger
  • Add rewind batch feature to the BatchEventProcessor
  • Add a maximum batch size argument to BatchEventProcessor
    • EventHandler::onBatchStart now gets both the batchSize as well as queueDepth (previously it had batchSize which reported queue depth)
  • Added documentation to EventPoller
  • Util::log2 throws if passed a non-positive argument
  • Deprecations
    • Deprecated ThreadHints.onSpinWait()
    • Deprecated Disruptor.handleExceptionsWith() - this had been javadoc deprecated since 2015 but not in the code
    • Removed previously deprecated methods
      • Ringbuffer.resetTo()
      • ConsumerRepository.getLastSequenceInChain()

Configuration

📅 Schedule: (UTC)

  • Branch creation
    • "before 9am on the first day of the month"
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot

@solrbot solrbot added the exempt-stale Prevent a PR from going stale label Sep 1, 2026
@github-actions github-actions Bot added the dependencies Dependency upgrades label Sep 1, 2026
@epugh

epugh commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Why didn't the unit tests run??? Shouldn't we run them to have some confidence in the fix? @janhoy

@epugh epugh self-assigned this Sep 1, 2026
@epugh

epugh commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

@janhoy @dsmiley you guys may want to look at this and weigh in.... I tweaked the solrj and crave tests to run when dependencies change so we can get that done as part of Solrbot...

@solrbot

solrbot commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator Author

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@epugh

epugh commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Ran bats test locally, all good.

@epugh
epugh requested review from dsmiley and janhoy September 1, 2026 20:23

@epugh epugh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tests all pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Dependency upgrades exempt-stale Prevent a PR from going stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants