SOLR-18417: Deprecate v1 PingRequestHandler and related code - #4872
SOLR-18417: Deprecate v1 PingRequestHandler and related code#4872gerlowskija wants to merge 2 commits into
Conversation
PingRequestHandler has largely been superseded by HealthcheckHandler (or
even SystemInfoHandler) which do healthchecks at the node-level instead
and tend to be much more compatible with typical load balancers.
This commit deprecates PingRequestHandler and the corresponding SolrPing
class in SolrJ. Removal will occur in a subsequent ('main'-only)
commit.
github-actions
Bot
added
documentation
gerlowskija
changed the title
|
Do you need to update https://solr.apache.org/guide/solr/latest/deployment-guide/ping.html ? Also, I feel like we need something like this page, but maybe we have a https://solr.apache.org/guide/solr/latest/deployment-guide/healthcheck.html page? |
|
Also, and i'm onboard with this, but we are removing the concept of a healthcheck from old non cloud deployments. Now, we are trying to get away from them, so I'm onboard. if you want helath checking, do |
We're removing PingRequestHandler, but Solr still offers a bunch of healthcheck options, even in standalone mode. HealthcheckHandler (and it's v2 equivalent) support standalone mode. As does SystemInfoHandler. And as we've discussed elsewhere - even for users who love the query-a-specific-core approach that PingRequestHandler provided -
I did! See |
|
FYI - I've created a draft PR here that actually removes this stuff. This other PR will go to 'main' only, and only after this deprecation PR makes it to 'main' + 'branch_10x' |
2 participants
PingRequestHandler has largely been superseded by HealthcheckHandler (or even SystemInfoHandler) which do healthchecks at the node-level instead and tend to be much more compatible with typical load balancers.
This commit deprecates PingRequestHandler and some related code, including the SolrPing and SolrPingResponse classes in SolrJ, and the
SolrClient.ping()methods on the SolrClient.Removal will be handled in a subsequent (main-only) PR.