SOLR-18169: Add IllegalArgumentException when slim image is used for … - #4876
Closed
r4mercur wants to merge 7 commits into
Closed
SOLR-18169: Add IllegalArgumentException when slim image is used for …#4876r4mercur wants to merge 7 commits into
r4mercur wants to merge 7 commits into
Conversation
…creating tech-products without documentation
epugh
reviewed
Sep 4, 2026
| closeables.add(executor); | ||
|
|
||
| RunExampleTool tool = new RunExampleTool(executor, System.in, runtime); | ||
| org.apache.commons.cli.CommandLine cli = SolrCLI.processCommandLineArgs(tool, toolArgs); |
Contributor
There was a problem hiding this comment.
do we need the full qulaified path? normally that is done via import, i would have expected a lint failure.
Contributor
|
can you also do the same thing for the |
epugh
requested changes
Sep 4, 2026
epugh
left a comment
epugh
left a comment
Contributor
There was a problem hiding this comment.
Needs to also handle films ;-)
Comment on lines
+414
to
+416
| "This Solr distribution does not include example data." | ||
| + "('slim' Docker image). Please use the full Solr " | ||
| + "distribution to run the techproducts example."); |
Contributor
There was a problem hiding this comment.
It is possible this is because of the slim docker image, but it's not the only reason.
Suggested change
| "This Solr distribution does not include example data." | |
| + "('slim' Docker image). Please use the full Solr " | |
| + "distribution to run the techproducts example."); | |
| "This Solr distribution does not include example data." | |
| + "This is expected when using the 'slim' Solr distribution." | |
| + "Please use the full Solr distribution to run the 'techproducts' example."); |
…g misleading exception message
…ate SchemaDesigner API (apache#4819)
…ache#4866) Signed-off-by: prithvi <prithvisivasankar@gmail.com> Co-authored-by: Eric Pugh <epugh@opensourceconnections.com>
github-actions
Bot
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…creating tech-products without documentation
https://issues.apache.org/jira/browse/SOLR-18169
Description
Our "slim" distribution shouldn't have examples.
Furthermore, an attempt to use bin/solr start -e techproducts etc. should yield a helpful error message.
Solution
Instead of write an simple echo() statement. I introduced an IllegalArgumentException with a more detailed error message. The message recommands the user to use the full docker image instead of the slim one.
AI Agents
I used claude agent for the explanation of the problem / description of the ticket. The testcase is also designed by the agent.
Tests
The testcase is simulating the "slim" distribution and checking that when there are no exampledocs that the new exception is thrown.
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.