[SPARK-57961][SQL][FOLLOW-UP][TESTS] Fix scalastyle line length violations in MetricsFailureInjectionSuite#57039
Closed
HyukjinKwon wants to merge 1 commit into
Closed
Conversation
…tricsFailureInjectionSuite Co-authored-by: Isaac
HyukjinKwon
changed the title
Member
Author
|
Merged to master, branch-4.x and branch-4.2. |
Member
Author
|
Merging this to recover CI |
HyukjinKwon
added a commit
that referenced
this pull request
Jul 6, 2026
…ons in MetricsFailureInjectionSuite ### What changes were proposed in this pull request? This is a follow-up of #57037 (SPARK-57959). That PR added an explanatory comment block to `MetricsFailureInjectionSuite`, and four of those comment lines exceed the 100-character limit, breaking the `scalastyle` check on `master`: ``` [error] .../MetricsFailureInjectionSuite.scala:348: File line length exceeds 100 characters [error] .../MetricsFailureInjectionSuite.scala:349: File line length exceeds 100 characters [error] .../MetricsFailureInjectionSuite.scala:352: File line length exceeds 100 characters [error] .../MetricsFailureInjectionSuite.scala:353: File line length exceeds 100 characters ``` This PR reflows the comment block so every line fits within 100 characters. No code or test logic is changed. ### Why are the changes needed? To fix the broken `scalastyle` check on `master` (and `branch-4.x`/`branch-4.2`, where the offending commit was also backported). ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? ``` grep -nP '.{101,}' sql/core/src/test/scala/org/apache/spark/sql/execution/metric/MetricsFailureInjectionSuite.scala ``` returns no matches. The change is comments-only. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Code (Opus 4.8) Closes #57039 from HyukjinKwon/fix/spark-57959-scalastyle-lines. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Hyukjin Kwon <hyukjin.kwon@databricks.com> (cherry picked from commit 4995e6f) Signed-off-by: Hyukjin Kwon <hyukjin.kwon@databricks.com>
HyukjinKwon
added a commit
that referenced
this pull request
Jul 6, 2026
…ons in MetricsFailureInjectionSuite ### What changes were proposed in this pull request? This is a follow-up of #57037 (SPARK-57959). That PR added an explanatory comment block to `MetricsFailureInjectionSuite`, and four of those comment lines exceed the 100-character limit, breaking the `scalastyle` check on `master`: ``` [error] .../MetricsFailureInjectionSuite.scala:348: File line length exceeds 100 characters [error] .../MetricsFailureInjectionSuite.scala:349: File line length exceeds 100 characters [error] .../MetricsFailureInjectionSuite.scala:352: File line length exceeds 100 characters [error] .../MetricsFailureInjectionSuite.scala:353: File line length exceeds 100 characters ``` This PR reflows the comment block so every line fits within 100 characters. No code or test logic is changed. ### Why are the changes needed? To fix the broken `scalastyle` check on `master` (and `branch-4.x`/`branch-4.2`, where the offending commit was also backported). ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? ``` grep -nP '.{101,}' sql/core/src/test/scala/org/apache/spark/sql/execution/metric/MetricsFailureInjectionSuite.scala ``` returns no matches. The change is comments-only. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Code (Opus 4.8) Closes #57039 from HyukjinKwon/fix/spark-57959-scalastyle-lines. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Hyukjin Kwon <hyukjin.kwon@databricks.com> (cherry picked from commit 4995e6f) Signed-off-by: Hyukjin Kwon <hyukjin.kwon@databricks.com>
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a follow-up of #57037 (SPARK-57959). That PR added an explanatory comment block to
MetricsFailureInjectionSuite, and four of those comment lines exceed the 100-character limit, breaking thescalastylecheck onmaster:This PR reflows the comment block so every line fits within 100 characters. No code or test logic is changed.
Why are the changes needed?
To fix the broken
scalastylecheck onmaster(andbranch-4.x/branch-4.2, where the offending commit was also backported).Does this PR introduce any user-facing change?
No.
How was this patch tested?
returns no matches. The change is comments-only.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.8)