Skip to content

[SPARK-57961][SQL][FOLLOW-UP][TESTS] Fix scalastyle line length violations in MetricsFailureInjectionSuite #57039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HyukjinKwon wants to merge 1 commit into from
Closed

[SPARK-57961][SQL][FOLLOW-UP][TESTS] Fix scalastyle line length violations in MetricsFailureInjectionSuite #57039

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions ...e/src/test/scala/org/apache/spark/sql/execution/metric/MetricsFailureInjectionSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,14 +343,15 @@ class MetricsFailureInjectionSuite
finalDf
}

// The INJECT_SHUFFLE_FETCH_FAILURES machinery corrupts mapper-0 of the first successful
// attempt of the shuffle map stage. Whether the downstream reducer observes the resulting
// FetchFailed (and thus forces the stage-1 recompute that inflates the raw metric) depends
// on task scheduling within the shared SparkContext; across the suite it occasionally does
// not fire, leaving stage1Metric at exactly 300 and failing "value > 300" (a ~1/6 flake,
// more frequent on slower runners such as macOS arm64). When we require a recompute
// (injectFailure = true), re-run the query until the injection actually fires. Each attempt
// resets the metrics, so a successful attempt is indistinguishable from a first-try success.
// The INJECT_SHUFFLE_FETCH_FAILURES machinery corrupts mapper-0 of the first
// successful attempt of the shuffle map stage. Whether the downstream reducer observes
// the resulting FetchFailed (and thus forces the stage-1 recompute that inflates the raw
// metric) depends on task scheduling within the shared SparkContext; across the suite it
// occasionally does not fire, leaving stage1Metric at exactly 300 and failing
// "value > 300" (a ~1/6 flake, more frequent on slower runners such as macOS arm64).
// When we require a recompute (injectFailure = true), re-run the query until the
// injection actually fires. Each attempt resets the metrics, so a successful attempt is
// indistinguishable from a first-try success.
var finalDf = runOnce()
if (injectFailure) {
var attempts = 1
Expand Down