[SPARK-58357][SQL] Remove unused withCatalogIdentClause in SparkSqlAstBuilder - #57548
Closed
uros-b wants to merge 1 commit into
Closed
[SPARK-58357][SQL] Remove unused withCatalogIdentClause in SparkSqlAstBuilder#57548uros-b wants to merge 1 commit into
uros-b wants to merge 1 commit into
Conversation
HyukjinKwon
approved these changes
Jul 26, 2026
uros-b
commented
Jul 26, 2026
uros-b
left a comment
uros-b
left a comment
Member
Author
There was a problem hiding this comment.
Thank you @HyukjinKwon! Waiting for CI
uros-b
added a commit
that referenced
this pull request
Jul 27, 2026
…tBuilder ### What changes were proposed in this pull request? Removes the unused private method `withCatalogIdentClause` in `SparkSqlAstBuilder`, along with the `SparkException` and `PlanWithUnresolvedIdentifier` imports that it was the sole remaining user of. ### Why are the changes needed? Its only caller (`visitSetCatalog`) was rewritten to call `expression(...)` directly, leaving the method with zero references. Removing it and its now-orphaned imports is dead-code cleanup with no behavior change. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pure removal of unreferenced code; existing parser tests unaffected. No new tests needed. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Code (Opus 4.8) Closes #57548 from uros-b/deadcode-sparksqlparser-withcatalogidentclause. Lead-authored-by: Uros Bojanic <221401595+uros-b@users.noreply.github.com> Co-authored-by: Uros Bojanic <uros.bojanic@databricks.com> Signed-off-by: Uros Bojanic <221401595+uros-b@users.noreply.github.com> (cherry picked from commit 781ca6a) Signed-off-by: Uros Bojanic <221401595+uros-b@users.noreply.github.com>
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Removes the unused private method
withCatalogIdentClauseinSparkSqlAstBuilder, along with theSparkExceptionandPlanWithUnresolvedIdentifierimports that it was the sole remaining user of.Why are the changes needed?
Its only caller (
visitSetCatalog) was rewritten to callexpression(...)directly, leaving the method with zero references. Removing it and its now-orphaned imports is dead-code cleanup with no behavior change.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pure removal of unreferenced code; existing parser tests unaffected. No new tests needed.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.8)