Skip to content

[SPARK-58357][SQL] Remove unused withCatalogIdentClause in SparkSqlAstBuilder #57548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
uros-b wants to merge 1 commit into from
Closed

[SPARK-58357][SQL] Remove unused withCatalogIdentClause in SparkSqlAstBuilder #57548

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 1 addition & 21 deletions sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,10 @@ import scala.jdk.CollectionConverters._
import org.antlr.v4.runtime.ParserRuleContext
import org.antlr.v4.runtime.tree.TerminalNode

import org.apache.spark.SparkException
import org.apache.spark.sql.catalyst.{FunctionIdentifier, TableIdentifier}
import org.apache.spark.sql.catalyst.analysis.{CurrentNamespace,
GlobalTempView, LocalTempView, PersistedView,
PlanWithUnresolvedIdentifier, SchemaEvolution, SchemaTypeEvolution, UnresolvedAttribute,
SchemaEvolution, SchemaTypeEvolution, UnresolvedAttribute,
UnresolvedIdentifier, UnresolvedNamespace, UnresolvedPartitionSpec, UnresolvedProcedure,
UnresolvedTableOrViewSearchPathMode}
import org.apache.spark.sql.catalyst.catalog._
Expand Down Expand Up @@ -314,25 +313,6 @@ class SparkSqlAstBuilder extends AstBuilder {
}
}

private def withCatalogIdentClause(
ctx: CatalogIdentifierReferenceContext,
builder: Seq[String] => LogicalPlan): LogicalPlan = {
val exprCtx = ctx.expression
if (exprCtx != null) {
// resolve later in analyzer
PlanWithUnresolvedIdentifier(withOrigin(exprCtx) { expression(exprCtx) }, Nil,
(ident, _) => builder(ident))
} else if (ctx.errorCapturingIdentifier() != null) {
// resolve immediately
builder.apply(Seq(getIdentifierText(ctx.errorCapturingIdentifier())))
} else if (ctx.stringLit() != null) {
// resolve immediately
builder.apply(Seq(string(visitStringLit(ctx.stringLit()))))
} else {
throw SparkException.internalError("Invalid catalog name")
}
}

/**
* Create a [[SetCommand]] logical plan.
*
Expand Down