Skip to content

fix: stringify scarf pixel value#26334

Closed
eschutho wants to merge 4 commits intoapache:masterfrom
preset-io:2023.51.1
Closed

fix: stringify scarf pixel value#26334
eschutho wants to merge 4 commits intoapache:masterfrom
preset-io:2023.51.1

Conversation

@eschutho
Copy link
Copy Markdown
Member

SUMMARY

In order to match the expression here: https://github.com/apache/superset/blob/master/superset-frontend/src/components/TelemetryPixel/index.tsx#L48
we need to cast the env var for SCARF_ANALYTICS to a string in the webpack config.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (04f1c35) 69.18% compared to head (9d86897) 69.18%.
Report is 13 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #26334      +/-   ##
==========================================
- Coverage   69.18%   69.18%   -0.01%     
==========================================
  Files        1945     1944       -1     
  Lines       75967    75969       +2     
  Branches     8466     8471       +5     
==========================================
  Hits        52556    52556              
+ Misses      21224    21223       -1     
- Partials     2187     2190       +3     
Flag Coverage Δ
hive 53.68% <66.66%> (+<0.01%) ⬆️
javascript 56.51% <ø> (+<0.01%) ⬆️
mysql 78.08% <100.00%> (-0.01%) ⬇️
postgres 78.17% <100.00%> (-0.01%) ⬇️
presto 53.63% <66.66%> (+<0.01%) ⬆️
python 82.86% <100.00%> (-0.01%) ⬇️
sqlite 76.83% <100.00%> (-0.01%) ⬇️
unit 55.81% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eschutho eschutho marked this pull request as ready for review December 23, 2023 00:02
@eschutho eschutho closed this Dec 23, 2023
@sadpandajoe sadpandajoe deleted the 2023.51.1 branch March 21, 2025 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants