Closed
Conversation
This reverts commit 2ac2892.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #26334 +/- ##
==========================================
- Coverage 69.18% 69.18% -0.01%
==========================================
Files 1945 1944 -1
Lines 75967 75969 +2
Branches 8466 8471 +5
==========================================
Hits 52556 52556
+ Misses 21224 21223 -1
- Partials 2187 2190 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
will add more tests in a separated PR (cherry picked from commit 3391e29)
…ry pixel (apache#26293)" This reverts commit eb4b412.
…ache#26011)" This reverts commit 8437a23.
51aa2f3 to
9d86897
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
In order to match the expression here: https://github.com/apache/superset/blob/master/superset-frontend/src/components/TelemetryPixel/index.tsx#L48
we need to cast the env var for SCARF_ANALYTICS to a string in the webpack config.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION