Skip to content

chore(mcp): remove unused MCP_SERVICE_HOST and MCP_SERVICE_PORT config - #42569

Merged
rusackas merged 1 commit into
apache:masterfrom
arijitroy003:fix/cleanup-unused-mcp-config
Jul 31, 2026
Merged

chore(mcp): remove unused MCP_SERVICE_HOST and MCP_SERVICE_PORT config#42569
rusackas merged 1 commit into
apache:masterfrom
arijitroy003:fix/cleanup-unused-mcp-config

Conversation

@arijitroy003

Copy link
Copy Markdown
Contributor

Summary

Remove unused MCP_SERVICE_HOST and MCP_SERVICE_PORT configuration variables that are defined but never consumed by the MCP service runtime.

Related to #42425

Changes

  • Remove MCP_SERVICE_HOST and MCP_SERVICE_PORT definitions from mcp_config.py
  • Remove corresponding entries from config dict export

Testing

Verified these variables are not imported or referenced by any runtime code.

These configuration variables are defined but never consumed by the
MCP service runtime. Removing dead config reduces confusion.

Related to apache#42425

Signed-off-by: arijitroy003 <arijitroy003@gmail.com>
@dosubot dosubot Bot added the change:backend Requires changing the backend label Jul 29, 2026
@bito-code-review

bito-code-review Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Code Review Agent Run #d2e0e1

Actionable Suggestions - 0
Review Details
  • Files reviewed - 1 · Commit Range: 62fea4c..62fea4c
    • superset/mcp_service/mcp_config.py
  • Files skipped - 0
  • Tools
    • MyPy (Static Code Analysis) - ✔︎ Successful
    • Astral Ruff (Static Code Analysis) - ✔︎ Successful
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by Bito Logo

@netlify

netlify Bot commented Jul 29, 2026

Copy link
Copy Markdown

Deploy Preview for superset-docs-preview ready!

Name Link
🔨 Latest commit 62fea4c
🔍 Latest deploy log https://app.netlify.com/projects/superset-docs-preview/deploys/6a69f47f7e419f0008abc351
😎 Deploy Preview https://deploy-preview-42569--superset-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov

codecov Bot commented Jul 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.28%. Comparing base (7999b74) to head (62fea4c).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #42569      +/-   ##
==========================================
- Coverage   65.29%   65.28%   -0.02%     
==========================================
  Files        2798     2798              
  Lines      158066   158164      +98     
  Branches    36133    36149      +16     
==========================================
+ Hits       103215   103257      +42     
- Misses      52856    52905      +49     
- Partials     1995     2002       +7     
Flag Coverage Δ
hive 38.25% <ø> (-0.02%) ⬇️
mysql 57.54% <ø> (-0.02%) ⬇️
postgres 57.57% <ø> (-0.02%) ⬇️
presto 40.16% <ø> (-0.02%) ⬇️
python 58.97% <ø> (-0.03%) ⬇️
sqlite 57.20% <ø> (-0.02%) ⬇️
unit 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rusackas
rusackas requested a review from aminghadersohi July 29, 2026 20:02
@arijitroy003 arijitroy003 changed the title Remove unused MCP_SERVICE_HOST and MCP_SERVICE_PORT config chore(mcp): remove unused MCP_SERVICE_HOST and MCP_SERVICE_PORT config Jul 30, 2026

@aminghadersohi aminghadersohi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the removed MCP_SERVICE_HOST / MCP_SERVICE_PORT are genuinely unreferenced by any code, so this is a safe dead-config cleanup.

Unreferenced check (whole-repo grep, symbol + string forms — python, helm, docker/compose, CI workflows, k8s, .env/config examples, frontend): No hits outside documentation. The MCP service actually binds via FASTMCP_HOST / FASTMCP_PORT (superset/mcp_service/__main__.py:166-168), not these constants. get_mcp_config() placed the two keys into app.config (flask_singleton.py:91-92), but nothing ever reads them back (no config["MCP_SERVICE_HOST"], os.environ, or .config.get for either key). The dict is informational and not serialized to any API/frontend contract, and no test references the keys. Confirmed dead.

Minor (docs consistency, not a blocker): These settings are still documented as "Host/Port the MCP server binds to" and should be removed/updated in the same spirit as this cleanup, since they no longer exist and never actually drove the bind:

  • docs/admin_docs/configuration/mcp-server.mdx:499-500 (and the versioned copy version-6.1.0/.../mcp-server.mdx:499-500, plus the example blocks at :382-383)
  • superset/mcp_service/PRODUCTION.md:499-500
  • UPDATING.md:794-795, 817-818

CI: All required checks pass. The single red is playwright-tests-experimental (chromium, /app/prefix), a non-required experimental matrix leg — an unrelated flaky embedded frontend test (playwright/tests/embedded/pivot-collapse-state.spec.ts, #33406) timing out on chart render across 2 retries. The sibling playwright-tests-experimental (chromium) leg passes, and a +0/-6 deletion of two unused Python constants cannot affect a browser e2e run. Unrelated to this change.

@rusackas
rusackas merged commit ec8405a into apache:master Jul 31, 2026
70 of 72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

change:backend Requires changing the backend size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants