feat(computing-unit-managing-service): let admins terminate any computing unit - #7337
Merged
Conversation
…ting unit Add an ADMIN bypass to terminateComputingUnit's owner guard: admins may terminate any unit, everyone else must still own it. A nonexistent cuid still 404s. Other owner-gated mutators (rename, /metrics, /limits) are unchanged. Adds the first terminateComputingUnit tests (admin-on-others, non-admin-denied, owner, nonexistent) and updates the AdminComputingUnitResource TODO. Closes apache#6478.
Contributor
Automated Reviewer SuggestionsBased on the
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7337 +/- ##
============================================
+ Coverage 83.42% 83.43% +0.01%
- Complexity 4137 4142 +5
============================================
Files 1167 1167
Lines 46443 46443
Branches 5174 5174
============================================
+ Hits 38743 38750 +7
+ Misses 5985 5979 -6
+ Partials 1715 1714 -1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Admins can now terminate any computing unit, not just their own.
terminateComputingUnitgated on ownership alone. This PR relaxes that guard so an ADMIN passes it.Any related issues, documentation, discussions?
Closes #6478.
How was this PR tested?
Added tests in
ComputingUnitManagingResourceSpecRun:
sbt "ComputingUnitManagingService/testOnly *ComputingUnitManagingResourceSpec"Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.8)