Fixed an error preventing Thrift::NonblockingServer from working with SSL#3307
Open
kpumuk wants to merge 1 commit intoapache:masterfrom
Open
Fixed an error preventing Thrift::NonblockingServer from working with SSL#3307kpumuk wants to merge 1 commit intoapache:masterfrom
kpumuk wants to merge 1 commit intoapache:masterfrom
Conversation
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
Thrift::NonblockingServerdoes not work when configured with SSL sockets:This is happening because
#to_ioon the SSL socket returns the wrapped handler instead of the underlying socket.After the change we get a clear output:
[skip ci]anywhere in the commit message to free up build resources.