Added --server-type argument to Ruby cross-tests integration server#3308
Open
kpumuk wants to merge 1 commit intoapache:masterfrom
Open
Added --server-type argument to Ruby cross-tests integration server#3308kpumuk wants to merge 1 commit intoapache:masterfrom
kpumuk wants to merge 1 commit intoapache:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on #3307, I wanted to test Nonblocking server with cross tests and notice that Ruby integration test server does not support server type selection. C++ adds
--server-typeargument, and Python accepts it as positional.This change adds
--server-typeand allows to run cross tests with different server types.Unsurprisingly, cross-tests passed for framed transport and failed for buffered: https://github.com/kpumuk/thrift/actions/runs/22001432085/job/63575905711 (which is not compatible with nonblocking server).
[skip ci]anywhere in the commit message to free up build resources.