Skip to content

Enable C++ TLS cross-tests - #3630

Merged
kpumuk merged 1 commit into
apache:masterfrom
kpumuk:cpp-ssl
Jul 12, 2026
Merged

Enable C++ TLS cross-tests#3630
kpumuk merged 1 commit into
apache:masterfrom
kpumuk:cpp-ssl

Conversation

@kpumuk

@kpumuk kpumuk commented Jul 11, 2026

Copy link
Copy Markdown
Member

C++ cross-test binaries assume TLS key files are at a fixed directory depth relative to the executable. This breaks with different build layouts, preventing otherwise working TLS cross-tests from running.

Instead, locate the test key directory by walking up from the executable path, with an explicit failure when it cannot be found. Re-enable the C++ TLS combinations that now pass.

  • Did you create an Apache Jira ticket? (Request account here, not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

Copilot AI review requested due to automatic review settings July 11, 2026 14:39
@mergeable mergeable Bot added c++ Pull requests that update C++ code testsuite labels Jul 11, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the C++ cross-test client/server to locate TLS key material more robustly by walking up from the executable location until test/keys is found, and re-enables several Linux cross-test TLS combinations that now succeed.

Changes:

  • Replace fixed “directory depth” key-path construction in C++ TestServer/TestClient with an upward search for the test/keys directory.
  • Add explicit failure when the key directory cannot be located.
  • Remove multiple C++↔Go and C++↔Python TLS cross-test entries from test/known_failures_Linux.json.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
test/known_failures_Linux.json Removes several TLS cross-test entries from the Linux known-failures list.
test/cpp/src/TestServer.cpp Updates TLS key/cert path discovery to search upward from the executable location.
test/cpp/src/TestClient.cpp Updates TLS key/cert path discovery to search upward from the executable location; adjusts debug output for testDir now being a filesystem path.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread test/cpp/src/TestServer.cpp Outdated
Comment thread test/cpp/src/TestClient.cpp Outdated
Copilot AI review requested due to automatic review settings July 11, 2026 14:50

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

Comment thread test/cpp/src/TestClient.cpp Outdated
Comment thread test/cpp/src/TestServer.cpp
Comment thread test/cpp/src/TestClient.cpp
Copilot AI review requested due to automatic review settings July 11, 2026 14:56

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

Comment thread test/cpp/src/TestServer.cpp
Comment thread test/cpp/src/TestClient.cpp
Client: cpp

Co-Authored-By: OpenAI Codex (GPT-5.4) <codex@openai.com>
Copilot AI review requested due to automatic review settings July 11, 2026 15:14

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

@Jens-G

Jens-G commented Jul 11, 2026

Copy link
Copy Markdown
Member

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

🤖 Generated with Claude Code

@kpumuk
kpumuk merged commit b3fa3ee into apache:master Jul 12, 2026
89 checks passed
@kpumuk
kpumuk deleted the cpp-ssl branch August 5, 2026 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Pull requests that update C++ code testsuite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants