Enable C++ TLS cross-tests - #3630
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the C++ cross-test client/server to locate TLS key material more robustly by walking up from the executable location until test/keys is found, and re-enables several Linux cross-test TLS combinations that now succeed.
Changes:
- Replace fixed “directory depth” key-path construction in C++ TestServer/TestClient with an upward search for the
test/keysdirectory. - Add explicit failure when the key directory cannot be located.
- Remove multiple C++↔Go and C++↔Python TLS cross-test entries from
test/known_failures_Linux.json.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test/known_failures_Linux.json | Removes several TLS cross-test entries from the Linux known-failures list. |
| test/cpp/src/TestServer.cpp | Updates TLS key/cert path discovery to search upward from the executable location. |
| test/cpp/src/TestClient.cpp | Updates TLS key/cert path discovery to search upward from the executable location; adjusts debug output for testDir now being a filesystem path. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Client: cpp Co-Authored-By: OpenAI Codex (GPT-5.4) <codex@openai.com>
Member
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. 🤖 Generated with Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
C++ cross-test binaries assume TLS key files are at a fixed directory depth relative to the executable. This breaks with different build layouts, preventing otherwise working TLS cross-tests from running.
Instead, locate the test key directory by walking up from the executable path, with an explicit failure when it cannot be found. Re-enable the C++ TLS combinations that now pass.
[skip ci]anywhere in the commit message to free up build resources.