THRIFT-6126: Handle unknown Compact and JSON types - #3681
Merged
Conversation
Client: rb Co-Authored-By: OpenAI Codex (GPT-5.6) <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ruby Compact and JSON protocol implementations currently allow unknown field and container type identifiers to escape as generic runtime exceptions. In
SimpleServer, those exceptions can leave the per-connection protocol error path and stop the accept loop, preventing a later valid client from being processed.This change reports unknown Compact and JSON types as
ProtocolException::INVALID_DATA. The native and pure-Ruby Compact implementations now expose matching exception metadata and preserve the original invalid writer type in diagnostics.SimpleServercan therefore close only the malformed connection and continue accepting clients.The fuzz harness now relies on these typed exceptions and drops obsolete message matching for invalid types, union validation, negative container sizes, and JSON encoding failures.
[skip ci]anywhere in the commit message to free up build resources.