THRIFT-2975 Graceful handling of server-side errors in Python#370
Closed
abhinav wants to merge 1 commit into
Closed
THRIFT-2975 Graceful handling of server-side errors in Python#370abhinav wants to merge 1 commit into
abhinav wants to merge 1 commit into
Conversation
Changes `process_*` functions to handle unexpected exceptions from user-supplied handlers by throwing a `TApplicationException(INTERNAL_ERROR)` to the client.
Author
|
This needs to log the actual exceptions before throwing TApplicationException to the clients and the clients need control of where the exceptions are logged. The current design doesn't cover that. Abandoning this diff to evaluate whether that's possible. |
Jens-G
pushed a commit
to Jens-G/thrift
that referenced
this pull request
Apr 14, 2019
…cs-more-readable reworded redis pub/sub doc to be more readable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
process_*functions to handle unexpected exceptions fromuser-supplied handlers by throwing a
TApplicationException(INTERNAL_ERROR)to the client.