Resolve config.h.in relative to ConfigureChecks.cmake - #3837
Open
jnordstrom-iar wants to merge 1 commit into
Open
Resolve config.h.in relative to ConfigureChecks.cmake#3837jnordstrom-iar wants to merge 1 commit into
jnordstrom-iar wants to merge 1 commit into
Conversation
mergeable
Bot
added
the
build and general CI
Member
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. 🤖 Generated with Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes such that we resolve the path to
config.h.inrelative toCMAKE_CURRENT_LIST_DIR, instead ofCMAKE_CURRENT_SOURCE_DIR. For us, this fixes an issue whenConfigureChecks.cmakeis included from an out-of-project CMakeLists.txt. Note thatCMAKE_CURRENT_LIST_DIRalways points tobuild/cmakeregardless of the caller, so this does not break the common use-case.Did you create an Apache Jira ticket? (Request account here, not required for trivial changes)If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?If your change does not involve any code, include[skip ci]anywhere in the commit message to free up build resources.