Follow on tweaks to the recent TIKA-2861 fix#2938
Open
tballison wants to merge 1 commit into
Open
Conversation
dschmidt
reviewed
Jul 9, 2026
dschmidt
left a comment
dschmidt
left a comment
Contributor
There was a problem hiding this comment.
Sweet, thanks for the cleanup!
dschmidt
reviewed
Jul 9, 2026
| tikaMetadata.set(TikaCoreProperties.LONGITUDE, location.longitude); | ||
| if (location.altitude != null) { | ||
| tikaMetadata.set(TikaCoreProperties.ALTITUDE, location.altitude); | ||
| } |
Contributor
There was a problem hiding this comment.
Wondering if tikaMetadata could be made aware of the ISO6709.Location type? Then 5 lines would shrink to one ... but maybe it's not a good idea for coupling reasons 🤷🏻♂️
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Contributor
There was a problem hiding this comment.
... unless it would become a generic Location class - with parseFromIso6709(), parseSomething() methods that would also parse other formats as well?
Was never a Java person, so not sure what's really idiomatic :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify regex Pattern. Follow up to #2935