TIKA-4776: Add regression test for Apple maker note LONG8 tags - #2981
Open
dschmidt wants to merge 1 commit into
Open
TIKA-4776: Add regression test for Apple maker note LONG8 tags#2981dschmidt wants to merge 1 commit into
dschmidt wants to merge 1 commit into
Conversation
metadata-extractor 2.21.0 (already bumped on main) decodes the LONG8 and SLONG8 TIFF format codes, so the Apple maker note tags written as LONG8 reach Tika now. The fixture is the still half of a real Apple Live Photo (iPhone 15 Pro, iOS 18.5) from the MIT licensed osxphotos test suite; the test pins the content identifier and the Live Photo ID (maker note tag 0x0017), which was dropped with metadata-extractor 2.20.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With metadata-extractor 2.21.0 on main the Apple maker note tags written as LONG8 (TIFF format code 16) come through, so this adds the regression test discussed in the ticket. The fixture is the still half of a real Apple Live Photo (iPhone 15 Pro, iOS 18.5) from the MIT licensed osxphotos test suite; the test asserts the content identifier and the Live Photo ID (maker note tag 0x0017, value 5283876), which metadata-extractor 2.20.0 silently dropped. With this in place TIKA-4776 can be resolved.