Traffic Portal dbdump failure shows no error message

[rawlinp]

If the DB Dump operation fails in Traffic Portal for whatever reason (e.g. you don't have the "admin" role and get a 403 Forbidden response from the API), that error is not displayed in the UI. In the case of not being an admin user, there should be a red error box at the top that says 403 Forbidden, making it obvious to the user that they do not have permission to use the DB Dump button.

[mitchell852]

I tried GET /api/1.4/dbdump with less than admin role and got this:

The 403 is correct but confused on a couple of things:

1. Where is the alerts array?
2. Why is data: ArrayBuffer(49) in there. Seems like it sends a 403 AND the contents of the dbdump...obviously, it shouldn't do that.

Even though it clearly looks like you get kicked out before doing the dbdump if you are not admin role:

https://github.com/apache/trafficcontrol/blob/master/traffic_ops/app/lib/API/Database.pm#L29

[rob05c]

Seems like it sends a 403 AND the contents of the dbdump...obviously, it shouldn't do that.

This may be fixed by #3165.

[mitchell852]

Seems like it sends a 403 AND the contents of the dbdump...obviously, it shouldn't do that.

This may be fixed by #3165.

Yes it did. Thanks!