API 1.x endpoint calls need to be updated to 2.0

[ericholguin]

I'm submitting a ...

• bug report
• new feature / enhancement request
• improvement request (usability, performance, tech debt, etc.)
• other

Traffic Control components affected ...

• CDN in a Box
• Documentation
• Grove
• Traffic Control Client
• Traffic Monitor
• Traffic Ops
• Traffic Ops ORT
• Traffic Portal
• Traffic Router
• Traffic Stats
• Traffic Vault
• unknown

Current behavior:

The following code needs to be updated to use 2.0:

trafficcontrol/test/router/server/server.go

Line 59 in 4b3d01d

if r.Method == "POST" && r.URL.Path == "/api/1.2/user/login" {

trafficcontrol/test/router/server/server.go

Line 67 in 4b3d01d

url := fmt.Sprintf("https://%v/api/1.2/user/login", r.URL.Query().Get("opsHost"))

trafficcontrol/traffic_ops/install/bin/copy-pgdata.sh

Line 59 in 4b3d01d

local url=$TO_URL/api/1.2/user/login

trafficcontrol/traffic_ops/install/bin/copy-pgdata.sh

Line 82 in 4b3d01d

to-get api/1.2/dbdump >"$dumpfile"

trafficcontrol/traffic_ops/install/bin/copy-pgdata.sh

Line 208 in 4b3d01d

cdns=$(to-get api/1.3/cdns | jq -Sr '.response|.[]|.name' | grep -v ALL)

trafficcontrol/traffic_ops/app/bin/checks/ToAutorenewCerts.pl

Line 83 in 4b3d01d

my $login_url = "$b_url/api/1.2/user/login";

trafficcontrol/traffic_ops/traffic_ops_golang/trafficstats/util_test.go

Line 54 in 4b3d01d

r, e := http.NewRequest(http.MethodGet, "https://example.test/api/1.4/deliveryservice_stats", nil)

trafficcontrol/traffic_ops/traffic_ops_golang/invalidationjobs/invalidationjobs.go

Line 365 in 4b3d01d

w.Header().Set(http.CanonicalHeaderKey("location"), inf.Config.URL.Scheme+"://"+r.Host+"/api/1.4/jobs?id="+strconv.FormatUint(uint64(*result.ID), 10))

trafficcontrol/traffic_ops/traffic_ops_golang/invalidationjobs/userinvalidationjobs.go

Line 137 in 4b3d01d

w.Header().Set(http.CanonicalHeaderKey("location"), inf.Config.URL.Scheme+"://"+r.Host+"/api/1.4/jobs?id="+strconv.FormatUint(uint64(*result.ID), 10))

Expected / new behavior:

Minimal reproduction of the problem with instructions:

Anything else:

[ocket8888]

Can we just get rid of copy-pgdata.sh? Isn't that a tool designed to help migrate from MySQL to PostgresQL?

[ocket8888]

The only of these not already fixed by #5539 are those in test/router - which doesn't work.

[zrhoffman]

The only of these not already fixed by #5539 are those in test/router - which doesn't work.

Grove API v1 references also need to be updated, and since Swagger contains API v1 references and we don't use it, we should just remove it.

[ocket8888]

Sure, but those aren't listed here. Are you going to add those to the issue? Because I was about to open a PR to update test/router references that would close this issue if that was all that was left.

[zrhoffman]

Oh neat, I'll add them to a new issue, then.