ORT: unavailable_server_retry_responses having parsing issues

[smalenfant]

I'm submitting a ...

• bug report

Traffic Control components affected ...

• Traffic Ops ORT

Current behavior:

Only quotes string with 2 parameters are valid for unavailable_server_retry_responses. Other valid string get ignored and parameters are not been written into the parent.config.

Expected behavior:

Setting unavailable_server_retry_responses to 503 should work. Shouldn't need to be quoted either.

Minimal reproduction of the problem with instructions:

set mso.unavailable_server_retry_responses to 503.
Result: ERROR: parentdotconfig.go:251: 2020-10-14T15:13:03.917552091Z: Malformed unavailable_server_retry_responses parameter '503', not using!

set mso.unavailable_server_retry_responses to "503".
Result: ERROR: parentdotconfig.go:251: 2020-10-14T15:49:28.583433821Z: Malformed unavailable_server_retry_responses parameter '"503"', not using!

set mso.unavailable_server_retry_responses to 502,503.
Result: ERROR: parentdotconfig.go:251: 2020-10-14T15:13:03.917599943Z: Malformed unavailable_server_retry_responses parameter '502,503', not using!

set mso.unavailable_server_retry_responses to "502,503".
Works.

[rob05c]

Bug is in the regex here:

trafficcontrol/lib/go-atscfg/parentdotconfig.go

Line 1091 in bcd54df

re := regexp.MustCompile(`^"(:?\d{3},)+\d{3}"\s*$`) // TODO benchmark, cache if performance matters

[mitchell852]

can u apply a severity level @smalenfant or @rob05c