Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

[Issue-1402] - adds profile list to GET parameters response to help identify orphan…#1621

Merged
dangogh merged 1 commit intoapache:masterfrom
mitchell852:issue-1402-adds-profile-count
Dec 27, 2017
Merged

[Issue-1402] - adds profile list to GET parameters response to help identify orphan…#1621
dangogh merged 1 commit intoapache:masterfrom
mitchell852:issue-1402-adds-profile-count

Conversation

@mitchell852
Copy link
Copy Markdown
Member

@mitchell852 mitchell852 commented Dec 6, 2017 •
edited
Loading

…ed parameters easily

fixes #1402
fixes #1363

@mitchell852 mitchell852 added Traffic Ops API (golang) Traffic Portal v1 related to Traffic Portal version 1 labels Dec 6, 2017
@asfgit
Copy link
Copy Markdown
Contributor

asfgit commented Dec 6, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/736/
Test PASSed.

@mitchell852 mitchell852 force-pushed the issue-1402-adds-profile-count branch from db9561a to 19aaf2c Compare December 6, 2017 22:50
@mitchell852 mitchell852 changed the title [Issue-1402] - adds profile count to GET parameters response to help identify orphan… [Issue-1402] - adds profile list to GET parameters response to help identify orphan… Dec 6, 2017
@mitchell852 mitchell852 force-pushed the issue-1402-adds-profile-count branch 2 times, most recently from 6d1d1f8 to b7bd445 Compare December 6, 2017 23:03
@asfgit
Copy link
Copy Markdown
Contributor

asfgit commented Dec 6, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/739/
Test PASSed.

@asfgit
Copy link
Copy Markdown
Contributor

asfgit commented Dec 6, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/740/
Test PASSed.

@mitchell852 mitchell852 force-pushed the issue-1402-adds-profile-count branch 3 times, most recently from 8eb4b76 to 92222d1 Compare December 7, 2017 20:09
@asfgit
Copy link
Copy Markdown
Contributor

asfgit commented Dec 7, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/745/
Test FAILed.

@asfgit
Copy link
Copy Markdown
Contributor

asfgit commented Dec 7, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/746/
Test FAILed.

@DylanVolz
Copy link
Copy Markdown

DylanVolz commented Dec 7, 2017

This looks good, I tested the sql locally.

@mitchell852 mitchell852 force-pushed the issue-1402-adds-profile-count branch 2 times, most recently from 67825fe to 5c21ce1 Compare December 13, 2017 22:47
@asfgit
Copy link
Copy Markdown
Contributor

asfgit commented Dec 13, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/785/
Test PASSed.

@asfgit
Copy link
Copy Markdown
Contributor

asfgit commented Dec 13, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/786/
Test PASSed.

@dangogh dangogh self-requested a review December 13, 2017 22:56
dangogh
dangogh suggested changes Dec 13, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@dangogh dangogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new entry in parameters JSON endpoint justifies moving to API version 1.3. However, profileList should just be profiles, and should be an array of profile names rather than comma-separated list. That makes it easier on the client to do something meaningful with the list.

@mitchell852
adds profiles array to each parameter. helps identify orphaned params…
ffaa8b0 
… as well as quickly show the profiles attached to a param
@mitchell852 mitchell852 force-pushed the issue-1402-adds-profile-count branch from 5c21ce1 to ffaa8b0 Compare December 21, 2017 18:19
@asfgit
Copy link
Copy Markdown
Contributor

asfgit commented Dec 21, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/822/
Test PASSed.

@dangogh dangogh merged commit af315e9 into apache:master Dec 27, 2017
@mitchell852 mitchell852 deleted the issue-1402-adds-profile-count branch February 22, 2018 19:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@dangogh dangogh dangogh requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dangogh dangogh

Labels

Traffic Portal v1 related to Traffic Portal version 1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TP - need to be able to view/manage orphaned parameters in Traffic Portal Profile Parameter Page Should List Profile(s)

4 participants

@mitchell852 @asfgit @DylanVolz @dangogh