Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

To go riak ping#2402

Merged
mitchell852 merged 1 commit into
apache:masterfrom
rob05c:to-go-riak-ping
Jul 10, 2018
Merged

To go riak ping#2402
mitchell852 merged 1 commit into
apache:masterfrom
rob05c:to-go-riak-ping

Conversation

@rob05c
Copy link
Copy Markdown
Member

@rob05c rob05c commented Jun 12, 2018 •
edited
Loading

No description provided.

@rob05c rob05c added new feature A new feature, capability or behavior Traffic Ops API (golang) labels Jun 12, 2018
@rob05c rob05c mentioned this pull request Jun 12, 2018
Closed
alficles
alficles reviewed Jun 12, 2018
View reviewed changes
Comment thread traffic_ops/traffic_ops_golang/ping/keys.go Outdated
Copy link
Copy Markdown
Contributor

@alficles alficles Jun 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused. Is this function supposed to be identical to the Riak function? Am I just missing something?

Copy link
Copy Markdown
Member Author

@rob05c rob05c Jun 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Identical, except it directly returns the status string. Yes, it reproduces the existing API. I make no warranty as to the quality or sanity of the existing API.

@asfgit
Copy link
Copy Markdown
Contributor

asfgit commented Jun 12, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/1797/
Test PASSed.

@rob05c rob05c force-pushed the to-go-riak-ping branch from a3dcdbd to a1562fc Compare June 13, 2018 14:51
@asfgit
Copy link
Copy Markdown
Contributor

asfgit commented Jun 13, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/1807/
Test PASSed.

@rob05c rob05c force-pushed the to-go-riak-ping branch from a1562fc to fb4b877 Compare June 19, 2018 21:39
@asfgit
Copy link
Copy Markdown
Contributor

asfgit commented Jun 20, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/1849/
Test PASSed.

@rob05c rob05c force-pushed the to-go-riak-ping branch from fb4b877 to 88abfe2 Compare June 25, 2018 15:08
@asfgit
Copy link
Copy Markdown
Contributor

asfgit commented Jun 25, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/1903/
Test PASSed.

alficles
alficles approved these changes Jun 25, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@alficles alficles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, this looks fine, then. It should be good to merge.

@mitchell852 mitchell852 self-assigned this Jul 2, 2018
@rob05c rob05c force-pushed the to-go-riak-ping branch from 88abfe2 to 4acdfc8 Compare July 9, 2018 17:30
@asfgit
Copy link
Copy Markdown
Contributor

asfgit commented Jul 9, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2047/
Test PASSed.

@mitchell852 mitchell852 merged commit 0f4874f into apache:master Jul 10, 2018
@rob05c rob05c deleted the to-go-riak-ping branch January 2, 2019 20:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@alficles alficles alficles approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mitchell852 mitchell852

Labels

new feature A new feature, capability or behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rob05c @asfgit @alficles @mitchell852