Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Conversation

@rob05c
Copy link
Member

@rob05c rob05c commented Jun 12, 2018

No description provided.

@rob05c rob05c added new feature A new feature, capability or behavior Traffic Ops API (golang) labels Jun 12, 2018
@asfgit
Copy link
Contributor

asfgit commented Jun 13, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/1798/
Test PASSed.

@rob05c rob05c force-pushed the to-go-user-current branch from 27d1c6c to 67c57f7 Compare June 13, 2018 14:51
@asfgit
Copy link
Contributor

asfgit commented Jun 13, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/1806/
Test PASSed.

@asfgit
Copy link
Contributor

asfgit commented Jun 20, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/1848/
Test PASSed.

@rob05c rob05c force-pushed the to-go-user-current branch from ce4536f to efba3ee Compare June 29, 2018 21:14
@asfgit
Copy link
Contributor

asfgit commented Jun 29, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/1940/
Test PASSed.

@asfgit
Copy link
Contributor

asfgit commented Jun 29, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/1941/
Test PASSed.

@DylanVolz
Copy link

This pr is ready to go, manually verified and all tests pass.

@rob05c rob05c force-pushed the to-go-user-current branch from 13c5ca2 to dc42ec9 Compare July 5, 2018 21:15
@rob05c rob05c force-pushed the to-go-user-current branch from dc42ec9 to 5b9840a Compare July 5, 2018 21:20
@asfgit
Copy link
Contributor

asfgit commented Jul 5, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2009/
Test PASSed.

@asfgit
Copy link
Contributor

asfgit commented Jul 5, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2010/
Test PASSed.

{1.1, http.MethodGet, `user/{id}/deliveryservices/available/?(\.json)?$`, user.GetAvailableDSes(d.DB), auth.PrivLevelReadOnly, Authenticated, nil},
{1.2, http.MethodPost, `user/login/?$`, wrapAccessLog(d.Secrets[0], auth.LoginHandler(d.DB, d.Config)), 0, NoAuth, nil}, {1.3, http.MethodPost, `user/login/?$`, auth.LoginHandler(d.DB, d.Config), 0, NoAuth, nil},
{1.2, http.MethodPost, `user/login/?$`, wrapAccessLog(d.Secrets[0], auth.LoginHandler(d.DB, d.Config)), 0, NoAuth, nil},
{1.3, http.MethodPost, `user/login/?$`, auth.LoginHandler(d.DB, d.Config), 0, NoAuth, nil},

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was an oversight that the wrapAccessLog was added to 1.2 and not to 1.3, it should be added here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@asfgit
Copy link
Contributor

asfgit commented Jul 5, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2011/
Test PASSed.

@elsloo elsloo self-assigned this Jul 6, 2018
@elsloo elsloo merged commit 5019995 into apache:master Jul 6, 2018
@rob05c rob05c deleted the to-go-user-current branch January 2, 2019 20:21
@ocket8888 ocket8888 mentioned this pull request Aug 13, 2019
2 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

new feature A new feature, capability or behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants