Fix delivery service validation#2451
Conversation
lib/go-tc/deliveryservices.go
Outdated
There was a problem hiding this comment.
Mind adding a Godoc function comment here, explaining the return params? That way someone doesn't have to read the function to figure out what each string being returned is.
lib/go-tc/tovalidate/rules.go
Outdated
There was a problem hiding this comment.
This function could be refactored to here: https://github.com/apache/trafficcontrol/blob/master/lib/go-tc/tovalidate/rules.go#L19
There was a problem hiding this comment.
am confused, this function is there
There was a problem hiding this comment.
sorry I didn't notice the package changed from above, ignore my previous comment
rawlinp
force-pushed
the
fix-ds-validation
branch
from
d4e047b to
488a59b
Compare
|
hold up, this makes |
|
Refer to this link for build results (access rights to CI server needed): |
Add the rest of the validation done by the Perl API that the Go API is missing. Fixes apache#2373
rawlinp
force-pushed
the
fix-ds-validation
branch
from
488a59b to
79af219
Compare
|
ok, fixed it so |
|
Refer to this link for build results (access rights to CI server needed): |
mitchell852
added
Traffic Ops API (golang)
bug
|
Refer to this link for build results (access rights to CI server needed): |
5 participants
Add the rest of the validation done by the Perl API that the Go API is
missing.
Fixes #2373