Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Add TO Go deliveryservices/id/capacity#2459

Merged
mitchell852 merged 1 commit intoapache:masterfrom
rob05c:to-go-ds-capacity
Dec 17, 2019
Merged

Add TO Go deliveryservices/id/capacity#2459
mitchell852 merged 1 commit intoapache:masterfrom
rob05c:to-go-ds-capacity

Conversation

@rob05c
Copy link
Copy Markdown
Member

@rob05c rob05c commented Jun 24, 2018 •
edited by ocket8888
Loading

Branched from #2305 - recommend merging that first. Closes #3788

@rob05c rob05c added new feature A new feature, capability or behavior Traffic Ops API (golang) labels Jun 24, 2018
@rob05c rob05c mentioned this pull request Jun 24, 2018
Closed
@asfgit
Copy link
Copy Markdown
Contributor

asfgit commented Jun 24, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/1901/
Test PASSed.

@rob05c rob05c force-pushed the to-go-ds-capacity branch from 21f6864 to 134c068 Compare July 9, 2018 19:50
@asfgit
Copy link
Copy Markdown
Contributor

asfgit commented Jul 9, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2059/
Test FAILed.

@rob05c rob05c force-pushed the to-go-ds-capacity branch from 134c068 to 6b5b830 Compare July 18, 2018 15:13
@asfgit
Copy link
Copy Markdown
Contributor

asfgit commented Jul 19, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2119/
Test FAILed.

This was referenced Aug 6, 2019
Closed
Closed
@rob05c rob05c force-pushed the to-go-ds-capacity branch 2 times, most recently from 77a64e6 to bd6e994 Compare August 16, 2019 18:19
@asfgit
Copy link
Copy Markdown
Contributor

asfgit commented Aug 16, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4164/
Test PASSed.

@mitchell852 mitchell852 self-assigned this Aug 21, 2019
@mitchell852 mitchell852 added Traffic Ops related to Traffic Ops tech debt rework due to choosing easy/limited solution and removed new feature A new feature, capability or behavior labels Aug 21, 2019
@rawlinp rawlinp added this to the Go Rewrite milestone Aug 22, 2019
mitchell852
mitchell852 suggested changes Oct 8, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@mitchell852 mitchell852 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this PR needs the changes made to #3927

@mitchell852 mitchell852 removed their assignment Dec 3, 2019
@rob05c rob05c force-pushed the to-go-ds-capacity branch 2 times, most recently from 6751eb1 to 9618774 Compare December 11, 2019 22:32
@asf-ci
Copy link
Copy Markdown
Contributor

asf-ci commented Dec 11, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4917/

@rob05c
Copy link
Copy Markdown
Member Author

rob05c commented Dec 11, 2019

Rebased with master and #2305, includes #3927 changes.
Manually tested again, still works as expected, still matches Perl.

@rob05c rob05c requested a review from mitchell852 December 11, 2019 22:51
@asf-ci
Copy link
Copy Markdown
Contributor

asf-ci commented Dec 11, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4920/

@asf-ci
Copy link
Copy Markdown
Contributor

asf-ci commented Dec 17, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4947/

@mitchell852 mitchell852 merged commit d7c43d3 into apache:master Dec 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mitchell852 mitchell852 Awaiting requested review from mitchell852

Assignees

No one assigned

Labels

tech debt rework due to choosing easy/limited solution Traffic Ops related to Traffic Ops

Projects

None yet

Milestone

Go Rewrite

Development

Successfully merging this pull request may close these issues.

Rewrite /deliveryservices/{{id}}/capacity to Go

6 participants

@rob05c @asfgit @asf-ci @mitchell852 @rawlinp @zrhoffman