Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Fix TO Go cdn dnssec generate to accept numbers #2720

Merged
dewrich merged 3 commits into from
Aug 21, 2018
Merged

Fix TO Go cdn dnssec generate to accept numbers #2720

dewrich merged 3 commits into from
Aug 21, 2018

Conversation

@rob05c
Copy link
Member

@rob05c rob05c commented Aug 20, 2018 •
edited
Loading

The docs say they're strings, but it appears Perl accepts both,
and the Portal sends numbers. This changes Go to emulate the Perl.

Fixes #2716

What does this PR do?

Fixes #2716

Which TC components are affected by this PR?

  • Documentation
  • Grove
  • Traffic Analytics
  • Traffic Monitor
  • Traffic Ops
  • Traffic Ops ORT
  • Traffic Portal
  • Traffic Router
  • Traffic Stats
  • Traffic Vault
  • Other _________

What is the best way to verify this PR?

Steps to Reproduce in #2716

Be aware this endpoint takes a long time, reproducing will likely require increasing http and db timeouts.

Check all that apply

  • This PR includes tests
  • This PR includes documentation updates
  • This PR includes an update to CHANGELOG.md
  • This PR includes all required license headers
  • This PR does NOT fix a serious security flaw. Read more: www.apache.org/security

@rob05c
Fix TO Go cdn dnssec generate to accept numbers
5861448 
The docs say they're strings, but it appears Perl accepts both,
and the Portal sends numbers. This changes Go to emulate the Perl.

Fixes apache#2716
@rob05c rob05c added bug something isn't working as intended Traffic Ops API (golang) labels Aug 20, 2018
@asfgit
Copy link
Contributor

asfgit commented Aug 20, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2299/
Test PASSed.

@dewrich
Copy link
Contributor

dewrich commented Aug 21, 2018 •
edited
Loading

@rob05c Just tested this PR and I'm getting this error now, see me for details:

image

@mitchell852
Copy link
Member

mitchell852 commented Aug 21, 2018 •
edited
Loading

@rob05c - can you write a unit test for this? or an integration test? or whatever makes the most sense?

@rob05c rob05c changed the title Fix TO Go cdn dnssec generate to accept numbers WIP Fix TO Go cdn dnssec generate to accept numbers Aug 21, 2018
@rob05c rob05c added the WIP "Work-in-Progress" - do not merge! (use 'draft' pull requests from now on) label Aug 21, 2018
@asfgit
Copy link
Contributor

asfgit commented Aug 21, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2303/
Test PASSed.

@rob05c rob05c changed the title WIP Fix TO Go cdn dnssec generate to accept numbers Fix TO Go cdn dnssec generate to accept numbers Aug 21, 2018
@rob05c rob05c removed the WIP "Work-in-Progress" - do not merge! (use 'draft' pull requests from now on) label Aug 21, 2018
@rob05c rob05c mentioned this pull request Aug 21, 2018
Closed
@rob05c
Copy link
Member Author

rob05c commented Aug 21, 2018 •
edited
Loading

@rob05c - can you write a unit test for this? or an integration test? or whatever makes the most sense?

@mitchell852 https://github.com/apache/trafficcontrol/pull/2720/files#diff-548856fd9ea3ae645fc12cb9afde3e31R31

@asfgit
Copy link
Contributor

asfgit commented Aug 21, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2308/
Test PASSed.

@dewrich dewrich merged commit eed18c9 into apache:master Aug 21, 2018
@rob05c rob05c deleted the to-go-fix-cdn-generate-dnssec branch January 2, 2019 20:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

bug something isn't working as intended

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

To go cdns dnssec generate does not work

4 participants

@rob05c @asfgit @dewrich @mitchell852