Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Fix TO Servers validation to allow "" ipv6#2845

Merged
mitchell852 merged 1 commit intoapache:masterfrom
rob05c:to-go-fix-server-ipv6-validation-allow-empty-str
Sep 20, 2018
Merged

Fix TO Servers validation to allow "" ipv6#2845
mitchell852 merged 1 commit intoapache:masterfrom
rob05c:to-go-fix-server-ipv6-validation-allow-empty-str

Conversation

@rob05c
Copy link
Copy Markdown
Member

@rob05c rob05c commented Sep 20, 2018

Fixes #2844

What does this PR do?

Fixes #2844

Which TC components are affected by this PR?

  • Documentation
  • Grove
  • Traffic Analytics
  • Traffic Monitor
  • Traffic Ops
  • Traffic Ops ORT
  • Traffic Portal
  • Traffic Router
  • Traffic Stats
  • Traffic Vault
  • Other _________

What is the best way to verify this PR?

Verify #2844

Check all that apply

  • This PR includes tests
  • This PR includes documentation updates
  • This PR includes an update to CHANGELOG.md
  • This PR includes all required license headers
  • This PR includes a database migration (ensure that migration sequence is correct)
  • This PR fixes a serious security flaw. Read more: www.apache.org/security

@rob05c rob05c added bug something isn't working as intended Traffic Ops API (golang) labels Sep 20, 2018
@asfgit
Copy link
Copy Markdown
Contributor

asfgit commented Sep 20, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2468/
Test PASSed.

@mitchell852
Copy link
Copy Markdown
Member

verified that a server with ip6Address empty string does not result in an error.

@mitchell852 mitchell852 self-assigned this Sep 20, 2018
@mitchell852 mitchell852 merged commit a1ed630 into apache:master Sep 20, 2018
@rob05c rob05c deleted the to-go-fix-server-ipv6-validation-allow-empty-str branch January 2, 2019 20:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug something isn't working as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Updating a server where ip6Address is blank results in API error

3 participants