This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Prohibit content invalidation requests for no-origin DS types #2858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rawlinp
added
bug
Prevent the submission of content invalidation requests against DS types that don't have origins (e.g. CLIENT_STEERING).
rawlinp
force-pushed
the
fix-jobs-with-no-origin
branch
from
7113ebc to
b18f625
Compare
alficles
suggested changes
Sep 21, 2018
| return $self->not_found(); | ||
| } | ||
| my $org_server_fqdn = UI::DeliveryService::compute_org_server_fqdn($self, $ds_id); | ||
| if ( !defined($org_server_fqdn) ) { |
Contributor
There was a problem hiding this comment.
Should check for empty string as well as !defined.
Contributor
Author
There was a problem hiding this comment.
The compute_org_server_fqdn function will never return an empty string, only undef or a valid-looking orgServerFqdn string built from the DS's primary origin.
Contributor
|
Refer to this link for build results (access rights to CI server needed): |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Prevent the submission of content invalidation requests against DS types
that don't have origins (e.g. CLIENT_STEERING).
Which TC components are affected by this PR?
What is the best way to verify this PR?
Submit a content invalidation job for a delivery service with an origin and make sure the API allows it. Then submit a job for a delivery service without an origin (like CLIENT_STEERING) and make sure the API prohibits it.
Check all that apply