Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

TO Client: no ids required in input json#2928

Merged
rawlinp merged 9 commits into
apache:masterfrom
dangogh:client-no-ids
Nov 2, 2018
Merged

TO Client: no ids required in input json#2928
rawlinp merged 9 commits into
apache:masterfrom
dangogh:client-no-ids

Conversation

@dangogh
Copy link
Copy Markdown
Member

@dangogh dangogh commented Oct 13, 2018

What does this PR do?

Removes requirement for providing IDs for foreign keys when using traffic ops client. Example: using client.CreateProfile, the Cdn field currently must be provided as cdnID. With this change, it can be provided instead as cdnName.

Which TC components are affected by this PR?

  • Documentation
  • Grove
  • Traffic Analytics
  • Traffic Monitor
  • Traffic Ops
  • Traffic Ops ORT
  • Traffic Portal
  • Traffic Router
  • Traffic Stats
  • Traffic Vault
  • Other _________

What is the best way to verify this PR?

The API tests have also been modified to take advantage of this capability. From traffic_ops/testing/api/v14, run go test -cfg ../conf/traffic_ops_test.conf to test.

Check all that apply

  • This PR includes tests
  • This PR includes documentation updates
  • This PR includes an update to CHANGELOG.md
  • This PR includes all required license headers
  • This PR includes a database migration (ensure that migration sequence is correct)
  • This PR fixes a serious security flaw. Read more: www.apache.org/security

@asfgit
Copy link
Copy Markdown
Contributor

asfgit commented Oct 13, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2608/
Test FAILed.

@dangogh dangogh changed the title Client no ids TO Client: no ids required in input json Oct 15, 2018
@dangogh dangogh added new feature A new feature, capability or behavior Traffic Ops Client labels Oct 15, 2018
@dangogh
Copy link
Copy Markdown
Member Author

dangogh commented Oct 17, 2018

retest this please

@asfgit
Copy link
Copy Markdown
Contributor

asfgit commented Oct 17, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2613/
Test PASSed.

@asfgit
Copy link
Copy Markdown
Contributor

asfgit commented Oct 18, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2615/
Test PASSed.

@asfgit
Copy link
Copy Markdown
Contributor

asfgit commented Oct 18, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2616/
Test PASSed.

Comment thread traffic_ops/testing/api/v14/tenants_test.go Outdated
@asfgit
Copy link
Copy Markdown
Contributor

asfgit commented Oct 29, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2675/
Test PASSed.

@asfgit
Copy link
Copy Markdown
Contributor

asfgit commented Oct 31, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2698/
Test PASSed.

@asfgit
Copy link
Copy Markdown
Contributor

asfgit commented Oct 31, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2699/
Test PASSed.

Comment thread traffic_ops/client/origin.go Outdated
Comment thread traffic_ops/testing/api/v14/user_test.go Outdated
@rawlinp rawlinp merged commit cae9c51 into apache:master Nov 2, 2018
@asfgit
Copy link
Copy Markdown
Contributor

asfgit commented Nov 2, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2713/
Test PASSed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

new feature A new feature, capability or behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants