Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

CDN-in-a-box trafficrouter uses openjdk#2936

Merged
mitchell852 merged 2 commits into
apache:masterfrom
dangogh:box-tr-openjdk
Nov 8, 2018
Merged

CDN-in-a-box trafficrouter uses openjdk#2936
mitchell852 merged 2 commits into
apache:masterfrom
dangogh:box-tr-openjdk

Conversation

@dangogh
Copy link
Copy Markdown
Member

@dangogh dangogh commented Oct 16, 2018

What does this PR do?

replaces oracle jdk with openjdk in cdn-in-a-box

Fixes #(issue_number)

Which TC components are affected by this PR?

  • Documentation
  • Grove
  • Traffic Analytics
  • Traffic Monitor
  • Traffic Ops
  • Traffic Ops ORT
  • Traffic Portal
  • Traffic Router
  • Traffic Stats
  • Traffic Vault
  • Other cdn-in-a-box

What is the best way to verify this PR?

cd infrastructure/cdn-in-a-box
docker-compose up -d

Run tests on trafficrouter container (help needed here)

Check all that apply

  • This PR includes tests
  • This PR includes documentation updates
  • This PR includes an update to CHANGELOG.md
  • This PR includes all required license headers
  • This PR includes a database migration (ensure that migration sequence is correct)
  • This PR fixes a serious security flaw. Read more: www.apache.org/security

@asfgit
Copy link
Copy Markdown
Contributor

asfgit commented Oct 16, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2610/
Test PASSed.

@dangogh dangogh added Traffic Router related to Traffic Router cdn-in-a-box related to the Docker-based CDN-in-a-Box system labels Oct 17, 2018
@ghost
Copy link
Copy Markdown

ghost commented Oct 31, 2018

Since we are now running with openjdk instead of oracle java, we should

  1. Install the traffic router via yum/rpm instead of unpacking it with rpm2cpio. I used the rpm2cpio method at the time due to issues in the RPMs that no longer exist.
  2. We don't need to build the tomcat-native manually at this point and can just install tomcat-native via yum/rpm.

Copy link
Copy Markdown
Contributor

@ajschmidt ajschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not :

ADD $TRAFFIC_ROUTER_RPM /
ADD $TOMCAT_RPM /

RUN yum install -y /$( basename $TOMCAT_RPM)
RUN yum install -y /$( basename $TRAFFIC_ROUTER_RPM)

@asfgit
Copy link
Copy Markdown
Contributor

asfgit commented Nov 6, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2743/
Test PASSed.

Copy link
Copy Markdown
Contributor

@ocket8888 ocket8888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This builds and runs in CIAB, and now that it's using yum instead of rpm2cpio I think this should work perfectly - pending #2960 to get Traffic Router to build for OpenJDK

@asfgit
Copy link
Copy Markdown
Contributor

asfgit commented Nov 7, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2748/
Test PASSed.

@mitchell852
Copy link
Copy Markdown
Member

merging based on @ocket8888 validation

@mitchell852 mitchell852 merged commit 44cc74d into apache:master Nov 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cdn-in-a-box related to the Docker-based CDN-in-a-Box system Traffic Router related to Traffic Router

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants