This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Update logrotate for grove and change some messaging from Error to Info level.#2982
Merged
Conversation
these messages are more informative than they are errors and they are filling up the error.logs. Also updates logrotate to add in error.log rotation.
Contributor
|
Refer to this link for build results (access rights to CI server needed): |
rob05c
approved these changes
Nov 1, 2018
Member
rob05c
left a comment
rob05c
left a comment
There was a problem hiding this comment.
These really are errors, I don't like changing them, but they happen too frequently to spam the error log, and we don't have a good fix for the problem at the moment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This changes some error messaging in grove to 'Info' log level as
these messages are more informative than they are errors and they are
filling up the error.logs. Also updates logrotate to add in error.log
rotation.
Fixes #(issue_number)
Which TC components are affected by this PR?
What is the best way to verify this PR?
/var/log/grove/error.log is rotated once it grows beyond 100m and no-longer logs messages about 'InterceptConn'.
Check all that apply