Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Change Monitor to third-party JSON, for performance#2999

Merged
mitchell852 merged 4 commits into
apache:masterfrom
rob05c:tm-third-party-json
Nov 19, 2018
Merged

Change Monitor to third-party JSON, for performance#2999
mitchell852 merged 4 commits into
apache:masterfrom
rob05c:tm-third-party-json

Conversation

@rob05c
Copy link
Copy Markdown
Member

@rob05c rob05c commented Nov 7, 2018

What does this PR do?

Change Monitor to third-party JSON, for performance

Which TC components are affected by this PR?

  • Documentation
  • Grove
  • Traffic Analytics
  • Traffic Monitor
  • Traffic Ops
  • Traffic Ops ORT
  • Traffic Portal
  • Traffic Router
  • Traffic Stats
  • Traffic Vault
  • Other _________

What is the best way to verify this PR?

Run the monitor, verify it generally works. This is an internal change, the interface does not change.

Check all that apply

  • This PR includes tests
  • This PR includes documentation updates
  • This PR includes an update to CHANGELOG.md
  • This PR includes all required license headers
  • This PR includes a database migration (ensure that migration sequence is correct)
  • This PR fixes a serious security flaw. Read more: www.apache.org/security

@rob05c rob05c added new feature A new feature, capability or behavior Traffic Monitor related to Traffic Monitor labels Nov 7, 2018
@asfgit
Copy link
Copy Markdown
Contributor

asfgit commented Nov 7, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2749/
Test FAILed.

@ezelkow1
Copy link
Copy Markdown
Member

ezelkow1 commented Nov 8, 2018

Just adding that I had tested json-iterator fastest mode briefly (not to this extent) and saw no issues with using that mode and it had a good reduction as far as memory and cpu usage percent by the json calls

Talking with Rob and from the documentation we might want to be careful though with un/marshalling anything that may have floats due to the loss of precision, though I dont think it currently affects anything we use. However in the future if we do we may need to fine tune the json-iterator mode for that specific use case

@mitchell852
Copy link
Copy Markdown
Member

mitchell852 commented Nov 16, 2018

retest this please

@asfgit
Copy link
Copy Markdown
Contributor

asfgit commented Nov 16, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2791/
Test FAILed.

@mitchell852
Copy link
Copy Markdown
Member

mitchell852 commented Nov 19, 2018

retest this please

@asfgit
Copy link
Copy Markdown
Contributor

asfgit commented Nov 19, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2808/
Test FAILed.

@rob05c rob05c force-pushed the tm-third-party-json branch from c719375 to b0c9624 Compare November 19, 2018 16:20
@asfgit
Copy link
Copy Markdown
Contributor

asfgit commented Nov 19, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2814/
Test FAILed.

@mitchell852 mitchell852 merged commit 69ea0f7 into apache:master Nov 19, 2018
@rob05c rob05c deleted the tm-third-party-json branch January 2, 2019 20:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@ezelkow1 ezelkow1 ezelkow1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

new feature A new feature, capability or behavior Traffic Monitor related to Traffic Monitor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rob05c @asfgit @ezelkow1 @mitchell852