Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Fix optional vnc container#3005

Merged
dangogh merged 4 commits intomasterfrom
unknown repository
Dec 7, 2018
Merged

Fix optional vnc container#3005
dangogh merged 4 commits intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Nov 9, 2018

What does this PR do?

This PR fixes a number of problems with the existing vnc testclient container:

Documentation updated. Depends on PR #3040

  1. rename the container to vnc since that is its purpose
  2. add vnc.infra.ciab.test hostname entry into the static dns server configuration.
  3. move the vnc container under the optional containers directory for better organization
  4. updates the shared volume required to get access to shared CA x509 SSL certificate
  5. fixes to allow firefox to start up in a container without dbus or systemd
  6. default vnc password is now random by default. Override via environment at runtime.
  7. Port changed to 5909 to avoid port collision

New proposed directory structure for optional containers:

cdn-in-a-box/optional
cdn-in-a-box/optional/docker-compose.$NAME.yml
cdn-in-a-box/optional/$NAME/

Which TC components are affected by this PR?

  • Documentation
  • Grove
  • Traffic Analytics
  • Traffic Monitor
  • Traffic Ops
  • Traffic Ops ORT
  • Traffic Portal
  • Traffic Router
  • Traffic Stats
  • Traffic Vault
  • Other cdn-in-a-box_______

What is the best way to verify this PR?

  1. Add VNC_PASSWD with six alphanumeric password to variables.env
  2. Start up the CIAB stack using the following alias:
alias vncdc='docker-compose -f docker-compose.yml -f optional/docker-compose.vnc.yml'
vncdc build 
vncdc kill && vncdc rm -fv 
docker volume prune -f
vncdc up
  1. Connect with vnc client to localhost 5909 with $VNC_PASSWD
  2. firefox should start as soon as the traffic portal is available.

Check all that apply

  • This PR includes tests
  • This PR includes documentation updates
  • This PR includes an update to CHANGELOG.md
  • This PR includes all required license headers
  • This PR includes a database migration (ensure that migration sequence is correct)
  • This PR fixes a serious security flaw. Read more: www.apache.org/security

@asfgit
Copy link
Copy Markdown
Contributor

asfgit commented Nov 9, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2758/
Test PASSed.

@asfgit
Copy link
Copy Markdown
Contributor

asfgit commented Nov 19, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2816/
Test FAILed.

@asfgit
Copy link
Copy Markdown
Contributor

asfgit commented Nov 19, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2817/
Test FAILed.

@ghost ghost mentioned this pull request Nov 19, 2018
17 tasks
Copy link
Copy Markdown
Contributor

@ocket8888 ocket8888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the official documentation at docs/source/admin/quick_howto/ciab.rst?

@ghost
Copy link
Copy Markdown
Author

ghost commented Nov 20, 2018

Absolutely.

@dangogh dangogh self-assigned this Nov 26, 2018
@dangogh dangogh added the cdn-in-a-box related to the Docker-based CDN-in-a-Box system label Nov 26, 2018
@ghost
Copy link
Copy Markdown
Author

ghost commented Dec 6, 2018

Documentation updated. Depends on PR #3040

@asfgit
Copy link
Copy Markdown
Contributor

asfgit commented Dec 6, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2903/
Test PASSed.

@asfgit
Copy link
Copy Markdown
Contributor

asfgit commented Dec 6, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2904/
Test FAILed.

@dangogh dangogh merged commit 78a4755 into apache:master Dec 7, 2018
@asfgit
Copy link
Copy Markdown
Contributor

asfgit commented Dec 7, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2916/
Test PASSed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cdn-in-a-box related to the Docker-based CDN-in-a-Box system

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants