Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Conversation

@ocket8888
Copy link
Contributor

@ocket8888 ocket8888 commented Nov 19, 2018

What does this PR do?

Removes JDNSSEC from Traffic Router's code base and build script.
Also includes documentation updates fixing some inaccuracies/things that were overlooked in previous updates, as well as spelling, grammar and indentation fixes.

Which TC components are affected by this PR?

  • Documentation
  • Grove
  • Traffic Analytics
  • Traffic Monitor
  • Traffic Ops
  • Traffic Ops ORT
  • Traffic Portal
  • Traffic Router
  • Traffic Stats
  • Traffic Vault
  • Other _________

What is the best way to verify this PR?

Try to build, install and test Traffic Router (tested with CIAB and appears to build and run fine under normal conditions, but CIAB doesn't support DNSSEC yet)

Check all that apply

  • This PR includes tests
  • This PR includes documentation updates
  • This PR includes an update to CHANGELOG.md
  • This PR includes all required license headers
  • This PR includes a database migration (ensure that migration sequence is correct)
  • This PR fixes a serious security flaw. Read more: www.apache.org/security

@asfgit
Copy link
Contributor

asfgit commented Nov 19, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2809/
Test PASSed.

@mitchell852
Copy link
Member

TR unit tests all pass? mvn clean test

@ocket8888
Copy link
Contributor Author

Tests are failing in master, so not sure

@asfgit
Copy link
Contributor

asfgit commented Nov 19, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2815/
Test PASSed.

@asfgit
Copy link
Contributor

asfgit commented Nov 19, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2819/
Test PASSed.

@ocket8888
Copy link
Contributor Author

Tests are passing, now that I know how to run them - this PR now also includes an update to the docs on how to run the tests.

@asfgit
Copy link
Contributor

asfgit commented Nov 20, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2822/
Test PASSed.

@dg4prez dg4prez merged commit 6c4c742 into apache:master Nov 21, 2018
@ocket8888 ocket8888 deleted the removing-jdnssec branch December 17, 2018 14:08
@mitchell852 mitchell852 added the Traffic Router related to Traffic Router label Feb 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Traffic Router related to Traffic Router

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants